Bug 191310 - Add onslotchange on ShadowRoot, SVG, and HTML elements
Summary: Add onslotchange on ShadowRoot, SVG, and HTML elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency tree / graph
 
Reported: 2018-11-06 10:15 PST by Ryosuke Niwa
Modified: 2021-08-21 22:14 PDT (History)
15 users (show)

See Also:

Attachments
Patch (63.95 KB, patch)
2020-10-02 08:16 PDT, Tetsuharu Ohzeki [UTC+9] 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (64.71 KB, patch)
2020-10-02 10:15 PDT, Tetsuharu Ohzeki [UTC+9] 		no flags Details | Formatted Diff | Diff
Patch (63.95 KB, patch)
2020-10-02 10:49 PDT, Tetsuharu Ohzeki [UTC+9] 		no flags Details | Formatted Diff | Diff
Patch (64.34 KB, patch)
2020-10-03 08:35 PDT, Tetsuharu Ohzeki [UTC+9] 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-11-06 10:15:48 PST 
See https://github.com/whatwg/html/issues/3487
Comment 1 Domenic Denicola 2019-09-19 20:50:02 PDT 
Spec pull request: https://github.com/whatwg/html/pull/4129 . It looks like we ended up using GlobalEventHandlers.

We are also considering adding it to ShadowRoot, but there's no spec PR for that yet.
Comment 2 Anne van Kesteren 2019-09-23 02:04:22 PDT 
There is now and I suspect we'll merge it once an editorial matter is resolved: https://github.com/whatwg/dom/pull/785.
Comment 3 Ryosuke Niwa 2019-10-08 19:29:24 PDT 
https://github.com/whatwg/html/pull/4129
Comment 4 Tetsuharu Ohzeki [UTC+9] 2020-10-02 08:16:42 PDT 
Created attachment 410325 [details]
Patch
Comment 5 Tetsuharu Ohzeki [UTC+9] 2020-10-02 10:15:38 PDT 
Created attachment 410334 [details]
Patch
Comment 6 Tetsuharu Ohzeki [UTC+9] 2020-10-02 10:49:09 PDT 
Created attachment 410337 [details]
Patch
Comment 7 Ryosuke Niwa 2020-10-02 19:18:49 PDT 
Comment on attachment 410337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410337&action=review

Looks okay to me but your change logs need some work.

> Source/WebCore/ChangeLog:7
> +

Could you add a description here?

> Source/WebCore/ChangeLog:9
> +        Tests:
> +            imported/w3c/web-platform-tests/dom/idlharness.window.html:

This isn't right. The first test name should appear after "Tests:" followed by a single space,
and the subsequent lines should appear aligned to that line:
e.g.
          Tests: imported/w3c/web-platform-tests/dom/idlharness.window.html
                 imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events.html
...

> LayoutTests/ChangeLog:7
> +

Say that you've rebaselined tests now that more test cases are passing.

> LayoutTests/imported/w3c/ChangeLog:7
> +

Ditto.
Comment 8 Tetsuharu Ohzeki [UTC+9] 2020-10-03 08:33:28 PDT 
Comment on attachment 410337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410337&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> Could you add a description here?

I thought this was self-obvious. I'll add a description.
Comment 9 Tetsuharu Ohzeki [UTC+9] 2020-10-03 08:35:13 PDT 
Created attachment 410424 [details]
Patch
Comment 10 EWS 2020-10-03 17:34:58 PDT 
Committed r267939: <https://trac.webkit.org/changeset/267939>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410424 [details].
Comment 11 Radar WebKit Bug Importer 2020-10-03 17:35:29 PDT 
<rdar://problem/69922171>