Bug 191291 – [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain

[Justin Fan]

Created attachment 353940 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/45829392>

[EWS Watchlist]

Attachment 353940 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:39:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 41 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Justin Fan]

For the style failure: IDL and binding code are expecting all-caps enums, at least in the current version of WebGPU.

[Justin Fan]

Created attachment 353993 [details]
Patch

[EWS Watchlist]

Attachment 353993 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:39:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Justin Fan]

Created attachment 354005 [details]
Patch

[EWS Watchlist]

Attachment 354005 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:39:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Justin Fan]

Created attachment 354018 [details]
Patch

[EWS Watchlist]

Attachment 354018 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:39:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Justin Fan]

Created attachment 354019 [details]
Patch

[EWS Watchlist]

Attachment 354019 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:39:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Justin Fan]

Created attachment 354034 [details]
Patch

[EWS Watchlist]

Attachment 354034 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:39:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Myles C. Maxfield]

Comment on attachment 354034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354034&action=review

> Source/WebCore/Modules/webgpu/GPUPipelineDescriptorBase.h:37
> +    Vector<GPUPipelineStageDescriptor> stages;

Are you sure this is the right internal design? We need to differentiate between the vertex shader and the fragment shader when we compile the state. That shouldn't have to iterate through a list of things just to find which item is for the fragment shader.

> Source/WebCore/Modules/webgpu/GPUPipelineStageDescriptor.h:37
> +    const GPUShaderModule& module;

What happens when the module gets garbage collected? Will this be dangling?

> Source/WebCore/Modules/webgpu/GPURenderPipelineDescriptor.h:37
> +struct GPURenderPipelineDescriptor : GPUPipelineDescriptorBase {

Why struct?

> Source/WebCore/Modules/webgpu/GPURenderPipelineDescriptor.h:52
> +    int primitiveTopology;

This shouldn't be an int.

> Source/WebCore/Modules/webgpu/WebGPUPipelineStageDescriptor.h:39
> +    const WebGPUShaderModule* module = nullptr;

Ditto about the garbage collector

> Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:36
> +    enum {

enum class

> Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:39
> +        VERTEX = 0,
> +        FRAGMENT = 1,
> +        COMPUTE = 2

Can we use different internal names for these? Our style is not to use ALL CAPS.

> Source/WebCore/Modules/webgpu/cocoa/GPURenderPipeline.h:50
> +#else
> +using PlatformRenderPipeline = void;
> +using PlatformRenderPipelineSmartPtr = RefPtr<void>;
> +#endif

I think it's fine to assume we're not using metal for now. We can break that assumption one day when the linux ports want WebGPU.

> Source/WebCore/Modules/webgpu/cocoa/GPURenderPipelineMetal.mm:88
> +    BEGIN_BLOCK_OBJC_EXCEPTIONS;

We should be deliberate about where we use these.

> Source/WebCore/bindings/js/WebCoreBuiltinNames.h:182
> +    macro(WebGPURenderPipeline) \
> +    macro(WebGPUShaderStage) \

Why aren't the other objects in here?

> LayoutTests/webgpu/render-pipelines.html:5
> +<script id="library" type="x-shader/x-metal">

😐

> LayoutTests/webgpu/webgpu-basics.html:129
> +    // let commandBuffer = defaultDevice.createCommandBuffer();
> +    // if (!commandBuffer) {
> +    //     testFailed("Could not create WebGPUCommandBuffer!");
> +    //     return;
> +    // }
> +
> +    // let texture = context.getNextTexture();
> +    // if (!texture) {
> +    //     testFailed("Could not get next WebGPUTexture!");
> +    //     return;
> +    // }
> +
> +    // let textureView = context.createTextureView();
> +    // if (!textureView) {
> +    //     testFailed("Could not create WebGPUTextureView!");
> +    //     return;
> +    // }
> +
> +    // // FIXME: Flesh out the rest of WebGPURenderPassDescriptor. Default loadOp, storeOp, clearColor for now.
> +    // let renderPassDescriptor = {
> +    //     attachment : textureView
> +    // };
> +
> +    // let renderPassEncoder = commandBuffer.beginRenderPass(renderPassDescriptor);
> +    // renderPassEncoder.setPipeline(renderPipeline);
> +
> +    // // Note that we didn't attach any buffers - the shader is generating the vertices for us.
> +    // renderPassEncoder.draw(3, 1, 0, 0);
> +    // renderPassEncoder.endPass();
> +
> +    // let queue = device.getQueue();
> +    // if (!queue) {
> +    //     testFailed("Unable to create default WebGPUQueue!");
> +    //     return;
> +    // }
> +    // queue.submit([commandBuffer]);
> +
> +    // context.present();

We don't leave code commented in WebKit.

[Justin Fan]

Created attachment 354047 [details]
Patch for landing

[Justin Fan]

Created attachment 354048 [details]
Patch for landing

[Justin Fan]

I'm removing the commented code from my test for now, but I will submit another patch to clean up the implementation after I get a demo working.

[EWS Watchlist]

Attachment 354048 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:37:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:38:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/Modules/webgpu/WebGPUShaderStage.h:39:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 3 in 56 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 354048 [details]
Patch for landing

Clearing flags on attachment: 354048

Committed r237912: <https://trac.webkit.org/changeset/237912>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.