Bug 191288 – Feature flags not present for Visual Studio when using build-webkit

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Don Olmstead]

Currently none of the feature flags selected in build-webkit end up being passed into a Visual Studio based build.

[Don Olmstead]

Created attachment 353925 [details]
Patch

[Don Olmstead]

*** Bug 190935 has been marked as a duplicate of this bug. ***

[Fujii Hironori]

Comment on attachment 353925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353925&action=review

> Tools/Scripts/build-webkit:303
> +    if (exitStatus(generateBuildSystemFromCMakeProject($prefixPath, (cmakeBasedPortArguments(), @featureArgs), @cmakeArgs))) {

cmakeBasedPortArguments is not used since Bug 136951. I think you should remove it.

[Fujii Hironori]

Comment on attachment 353925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353925&action=review

>> Tools/Scripts/build-webkit:303
>> +    if (exitStatus(generateBuildSystemFromCMakeProject($prefixPath, (cmakeBasedPortArguments(), @featureArgs), @cmakeArgs))) {
> 
> cmakeBasedPortArguments is not used since Bug 136951. I think you should remove it.

This inner parenthesis is useless in Perl because Perl flattens nested lists.
generateBuildSystemFromCMakeProject($prefixPath, cmakeBasedPortArguments(), @featureArgs, @cmakeArgs)

[Don Olmstead]

Created attachment 353984 [details]
Patch

Updated based on review comments. Removed the unused cmakeBasedPortArguments.

[WebKit Commit Bot]

Comment on attachment 353984 [details]
Patch

Clearing flags on attachment: 353984

Committed r237887: <https://trac.webkit.org/changeset/237887>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45855617>