WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
191286
Add a pseudoclass that matches img elements that are backed by an attachment
https://bugs.webkit.org/show_bug.cgi?id=191286
Summary
Add a pseudoclass that matches img elements that are backed by an attachment
mitz
Reported
2018-11-05 15:36:13 PST
It would be useful to have a way to select img elements that are using an attachment as their data source.
Attachments
WIP
(4.01 KB, patch)
2018-11-05 17:53 PST
,
mitz
no flags
Details
Formatted Diff
Diff
WIP
(8.97 KB, patch)
2018-11-06 14:53 PST
,
mitz
no flags
Details
Formatted Diff
Diff
Introduce :has-attachment
(12.44 KB, patch)
2018-11-06 16:23 PST
,
mitz
dino
: review+
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews201 for win-future
(12.78 MB, application/zip)
2018-11-06 19:51 PST
,
EWS Watchlist
no flags
Details
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
2018-11-05 15:38:01 PST
<
rdar://problem/45823554
>
mitz
Comment 2
2018-11-05 17:53:34 PST
Created
attachment 353935
[details]
WIP
mitz
Comment 3
2018-11-06 14:53:48 PST
Created
attachment 354012
[details]
WIP
mitz
Comment 4
2018-11-06 16:23:37 PST
Created
attachment 354024
[details]
Introduce :has-attachment Some things that need review here: - the name of the pseudoclass - the way it’s made to not parse at runtime if the attachment element isn’t enabled - the lack of an explicit mechanism to force style resolution when an img gains an attachment, because currently the DOM tree mutation just makes it work
EWS Watchlist
Comment 5
2018-11-06 19:51:06 PST
Comment on
attachment 354024
[details]
Introduce :has-attachment
Attachment 354024
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/9887671
New failing tests: fast/css/has-attachment.html
EWS Watchlist
Comment 6
2018-11-06 19:51:17 PST
Created
attachment 354053
[details]
Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Simon Fraser (smfr)
Comment 7
2018-11-07 11:13:02 PST
If this is apple-internal only, should it have a -apple- prefix?
mitz
Comment 8
2018-11-07 11:34:13 PST
Committed <
https://trac.webkit.org/r237932
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug