List all installed SDKs with version numbers stripped out.
<rdar://problem/45703660>
Created attachment 353899 [details] Patch
Comment on attachment 353899 [details] Patch Clearing flags on attachment: 353899 Committed r237836: <https://trac.webkit.org/changeset/237836>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45825307>
Reopening to attach new patch.
Created attachment 353970 [details] Patch
Created attachment 353991 [details] Patch
Comment on attachment 353991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353991&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:84 > + return ['--sdk', self.SDK] + (['ARCHS={}'.format(self.architecture())] if self.architecture() else []) Is the architecture change unrelated? If so, it probably needs to be in a separate patch.
Created attachment 354004 [details] Patch
(In reply to Aakash Jain from comment #9) > Comment on attachment 353991 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353991&action=review > > > Tools/Scripts/webkitpy/port/ios_simulator.py:84 > > + return ['--sdk', self.SDK] + (['ARCHS={}'.format(self.architecture())] if self.architecture() else []) > > Is the architecture change unrelated? If so, it probably needs to be in a > separate patch. It was some code clean-up, I removed it. (It wasn't actually a functional change)
Comment on attachment 354004 [details] Patch Clearing flags on attachment: 354004 Committed r237913: <https://trac.webkit.org/changeset/237913>
Reverted r237913 for reason: Breaks running tests on Mac without iOS SDK installed Committed r237931: <https://trac.webkit.org/changeset/237931>
(In reply to Jonathan Bedard from comment #14) > Reverted r237913 for reason: > > Breaks running tests on Mac without iOS SDK installed > > Committed r237931: <https://trac.webkit.org/changeset/237931> I'll re-land this tonight, this patch was (and is) fine, there is just a specific local configuration problem that causes this patch to fail, I'll reach out to those who might be impacted.
Comment on attachment 354004 [details] Patch Rejecting attachment 354004 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 354004, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9904967
Committed r237989: <https://trac.webkit.org/changeset/237989>