Bug 191275 – webkitpy: Generalize trailing SDK specifier

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

List all installed SDKs with version numbers stripped out.

[Jonathan Bedard]

<rdar://problem/45703660>

[Jonathan Bedard]

Created attachment 353899 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 353899 [details]
Patch

Clearing flags on attachment: 353899

Committed r237836: <https://trac.webkit.org/changeset/237836>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45825307>

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 353970 [details]
Patch

[Jonathan Bedard]

Created attachment 353991 [details]
Patch

[Aakash Jain]

Comment on attachment 353991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353991&action=review

> Tools/Scripts/webkitpy/port/ios_simulator.py:84
> +        return ['--sdk', self.SDK] + (['ARCHS={}'.format(self.architecture())] if self.architecture() else [])

Is the architecture change unrelated? If so, it probably needs to be in a separate patch.

[Jonathan Bedard]

Created attachment 354004 [details]
Patch

[Jonathan Bedard]

(In reply to Aakash Jain from comment #9)
> Comment on attachment 353991 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353991&action=review
> 
> > Tools/Scripts/webkitpy/port/ios_simulator.py:84
> > +        return ['--sdk', self.SDK] + (['ARCHS={}'.format(self.architecture())] if self.architecture() else [])
> 
> Is the architecture change unrelated? If so, it probably needs to be in a
> separate patch.

It was some code clean-up, I removed it. (It wasn't actually a functional change)

[WebKit Commit Bot]

Comment on attachment 354004 [details]
Patch

Clearing flags on attachment: 354004

Committed r237913: <https://trac.webkit.org/changeset/237913>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jonathan Bedard]

Reverted r237913 for reason:

Breaks running tests on Mac without iOS SDK installed

Committed r237931: <https://trac.webkit.org/changeset/237931>

[Jonathan Bedard]

(In reply to Jonathan Bedard from comment #14)
> Reverted r237913 for reason:
> 
> Breaks running tests on Mac without iOS SDK installed
> 
> Committed r237931: <https://trac.webkit.org/changeset/237931>

I'll re-land this tonight, this patch was (and is) fine, there is just a specific local configuration problem that causes this patch to fail, I'll reach out to those who might  be impacted.

[WebKit Commit Bot]

Comment on attachment 354004 [details]
Patch

Rejecting attachment 354004 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 354004, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/9904967

[Jonathan Bedard]

Committed r237989: <https://trac.webkit.org/changeset/237989>