RESOLVED FIXED191262
Make mDNS ICE Candidate an experimental flag again 
https://bugs.webkit.org/show_bug.cgi?id=191262
Summary Make mDNS ICE Candidate an experimental flag again
youenn fablet
Reported 2018-11-05 07:07:28 PST
This was moved to internal setting.
Attachments
Patch (1.22 KB, patch)
2018-11-05 07:08 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.25 KB, patch)
2018-11-05 20:39 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-11-05 07:08:12 PST
Created attachment 353861 [details] Patch
Dean Jackson
Comment 2 2018-11-05 13:21:19 PST
Comment on attachment 353861 [details] Patch You should move the entire feature into the Experimental Features section. And you should give it a better name e.g. "WebRTC: MDNS ICE candidates".
youenn fablet
Comment 3 2018-11-05 20:39:27 PST
Created attachment 353944 [details] Patch
youenn fablet
Comment 4 2018-11-05 20:40:19 PST
(In reply to Dean Jackson from comment #2) > Comment on attachment 353861 [details] > Patch > > You should move the entire feature into the Experimental Features section. > And you should give it a better name e.g. "WebRTC: MDNS ICE candidates". Done, I also renamed the option to webRTC... This made the patch bigger so let's do another round of review.
WebKit Commit Bot
Comment 5 2018-11-06 17:57:46 PST
Comment on attachment 353944 [details] Patch Clearing flags on attachment: 353944 Committed r237905: <https://trac.webkit.org/changeset/237905>
WebKit Commit Bot
Comment 6 2018-11-06 17:57:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-06 17:58:21 PST
<rdar://problem/45862665>
Note You need to log in before you can comment on or make changes to this bug.