Bug 191261 – Calling sender.replaceTrack() twice produces a new transceiver and its corresponding m= section

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Iñaki Baz]

Created attachment 353860 [details]
Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled.

Scenario:

* Have a pc with an audio transceiver for just sending.

* Do transceiver.sender.replaceTrack(null) and renegotiate.

* Do transceiver.sender.replaceTrack(track) and renegotiate.

After that, we have two audio transceivers so two m=audio sections. Of course this should not happen. It works fine in Chrome and Firefox.

Script attached.

[youenn fablet]

This is a left over of plan B/unified plan migration.
Will fix it

[youenn fablet]

Created attachment 353952 [details]
Patch

[Eric Carlson]

Comment on attachment 353952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353952&action=review

> Source/WebCore/ChangeLog:11
> +        Covered by updated test.

Nit: you should mention that you updated webrtc/video-addTransceiver.html to test this.

[youenn fablet]

Created attachment 354040 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 354040 [details]
Patch for landing

Clearing flags on attachment: 354040

Committed r237910: <https://trac.webkit.org/changeset/237910>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45864192>

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 353952 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353952&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Covered by updated test.
> 
> Nit: you should mention that you updated webrtc/video-addTransceiver.html to
> test this.

Thanks for the review.
Done!