Bug 191260 - Setting transceiver.direction = "inactive" is ignored
Summary: Setting transceiver.direction = "inactive" is ignored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-05 06:47 PST by Iñaki Baz
Modified: 2018-12-06 03:39 PST (History)
1 user (show)

See Also:

Attachments
Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled. (2.63 KB, text/javascript)
2018-11-05 06:47 PST, Iñaki Baz 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iñaki Baz 2018-11-05 06:47:08 PST 
Created attachment 353859 [details]
Script that reproduces the issue. Just run it in Safari 12.1 console with "Unified-Plan" enabled.

Scenario:

* Have a pc with an audio transceiver for just sending audio (it does not receive audio from the remote), so it has `direction: "sendonly"`.

* Call `transceiver.sender.replaceTrack(null)` and `transceiver.direction = "inactive"` and do a new SDP O/A.

* No matter where `transceiver.direction = "inactive"` is set. The `transceiver.direction` remains "sendonly" and its m=audio section also remains with "a=sendonly".

This works as expected in Chrome and Firefox.

Script attached.
Comment 1 Iñaki Baz 2018-11-13 16:05:58 PST 
Hi, any news about this issue?
Comment 2 youenn fablet 2018-11-13 16:52:09 PST 
(In reply to Iñaki Baz from comment #1)
> Hi, any news about this issue?

Will look at it this week.
Comment 3 youenn fablet 2018-11-13 16:57:55 PST 
Using WebKit Tot, your test case works as expected.
Let's mark it as fixed for now.
Please reopen if next STP version is not working as expected.
Comment 4 Iñaki Baz 2018-11-19 13:02:15 PST 
Hi, I've tested in latest STP: Release 70 (Safari 12.1, WebKit 14607.1.13)

The attached still fails (direction remains a=sendonly instead of a=inactive).

Should I wait for next STP?
Comment 5 Iñaki Baz 2018-12-06 03:39:57 PST 
ok, it works today in latest (Safari 12.1, WebKit 14607.1.15.

Good work :)