Bug 191256 – Fix build with disabled DFG/FTL

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dominik Inführ]

Fix build with disabled DFG/FTL[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[D[C

[Dominik Inführ]

Created attachment 353845 [details]
Patch

[Dominik Inführ]

Created attachment 353846 [details]
Patch

[Guillaume Emont]

Comment on attachment 353846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353846&action=review

Did not try it yet, but the changes seem to make sense.
One suggestion for improvement though: the implementation of GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback() in bytecode/GetByIdStatus.cpp does not seem to be guarded by ENABLE(DFG_JIT) even though its definition in the .h is, so maybe we want to guard it too?

> Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:-55
> -#if ENABLE(DFG_JIT)
> -ExitFlag PutByIdStatus::hasExitSite(CodeBlock* profiledBlock, unsigned bytecodeIndex)
> -{
> -    return hasBadCacheExitSite(profiledBlock, bytecodeIndex);
> -}
> -#endif

Any idea why this function existed in the first place?

[Dominik Inführ]

After looking into the history, it seems that the function used to do more stuff.

[Guillaume Emont]

(In reply to Guillaume Emont from comment #3)
> One suggestion for improvement though: the implementation of
> GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback() in
> bytecode/GetByIdStatus.cpp does not seem to be guarded by ENABLE(DFG_JIT)
> even though its definition in the .h is, so maybe we want to guard it too?

Disregard that, I got mixed up between GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback() and InByIdStatus::computeForStubInfoWithoutExitSiteFeedback().

[Dominik Inführ]

Created attachment 353873 [details]
Patch

[Dominik Inführ]

ping review.

[Yusuke Suzuki]

Comment on attachment 353873 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 353873 [details]
Patch

Clearing flags on attachment: 353873

Committed r238346: <https://trac.webkit.org/changeset/238346>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.