Bug 191254 - Align wide opcodes in the instruction stream
Summary: Align wide opcodes in the instruction stream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-05 01:59 PST by Tadeu Zagallo
Modified: 2018-11-07 11:38 PST (History)
9 users (show)

See Also:

Attachments
Patch (32.26 KB, patch)
2018-11-05 02:09 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch (32.31 KB, patch)
2018-11-05 08:37 PST, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.73 MB, application/zip)
2018-11-05 13:45 PST, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2018-11-05 01:59:01 PST 
Pad the bytecode with nops to ensure that wide opcodes are 4-byte aligned on platforms that don't like unaligned memory access.
Comment 1 Tadeu Zagallo 2018-11-05 02:09:39 PST 
Created attachment 353839 [details]
Patch
Comment 2 Tadeu Zagallo 2018-11-05 08:37:56 PST 
Created attachment 353865 [details]
Patch
Comment 3 Tadeu Zagallo 2018-11-05 09:17:09 PST 
<rdar://problem/45739094>
Comment 4 EWS Watchlist 2018-11-05 13:45:35 PST 
Comment on attachment 353865 [details]
Patch

Attachment 353865 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9869160

New failing tests:
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html
Comment 5 EWS Watchlist 2018-11-05 13:45:37 PST 
Created attachment 353905 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 Keith Miller 2018-11-07 11:02:49 PST 
Comment on attachment 353865 [details]
Patch

r=me.
Comment 7 WebKit Commit Bot 2018-11-07 11:38:23 PST 
Comment on attachment 353865 [details]
Patch

Clearing flags on attachment: 353865

Committed r237933: <https://trac.webkit.org/changeset/237933>
Comment 8 WebKit Commit Bot 2018-11-07 11:38:25 PST 
All reviewed patches have been landed.  Closing bug.