Bug 191251 - Remove some virtual methods in CachedRawResource
Summary: Remove some virtual methods in CachedRawResource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-05 01:25 PST by Rob Buis
Modified: 2018-11-05 05:56 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.98 KB, patch)
2018-11-05 01:27 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (2.07 KB, patch)
2018-11-05 04:59 PST, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (2.07 KB, patch)
2018-11-05 05:15 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2018-11-05 01:25:01 PST
Remove some virtual methods in CachedRawResource, as CachedRawResource is final no need to introduce new virtual methods in CachedRawResource.
Comment 1 Rob Buis 2018-11-05 01:27:18 PST
Created attachment 353837 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-11-05 04:50:59 PST
Comment on attachment 353837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review

> Source/WebCore/loader/cache/CachedRawResource.h:-40
> -    // This can be fixed by splitting CORS preflighting out of DocumentThreacableLoader.

What's this FIXME referring to? Is it just an obsolete comment? Can you mention in the ChangeLog why we remove this?
Comment 3 Frédéric Wang (:fredw) 2018-11-05 04:52:05 PST
Comment on attachment 353837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review

> Source/WebCore/loader/cache/CachedRawResource.h:-32
> -class SubresourceLoader;

Can we also briefly mention this change in the ChangeLog too?
Comment 4 Rob Buis 2018-11-05 04:59:32 PST
Created attachment 353851 [details]
Patch
Comment 5 Rob Buis 2018-11-05 05:00:22 PST
Comment on attachment 353851 [details]
Patch

Updated commit message after Fred's feedback.
Comment 6 WebKit Commit Bot 2018-11-05 05:02:01 PST
Comment on attachment 353851 [details]
Patch

Rejecting attachment 353851 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 353851, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/9863899
Comment 7 Rob Buis 2018-11-05 05:15:59 PST
Created attachment 353852 [details]
Patch
Comment 8 WebKit Commit Bot 2018-11-05 05:55:28 PST
Comment on attachment 353852 [details]
Patch

Clearing flags on attachment: 353852

Committed r237797: <https://trac.webkit.org/changeset/237797>
Comment 9 WebKit Commit Bot 2018-11-05 05:55:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-11-05 05:56:22 PST
<rdar://problem/45805544>