Remove some virtual methods in CachedRawResource, as CachedRawResource is final no need to introduce new virtual methods in CachedRawResource.
Created attachment 353837 [details] Patch
Comment on attachment 353837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review > Source/WebCore/loader/cache/CachedRawResource.h:-40 > - // This can be fixed by splitting CORS preflighting out of DocumentThreacableLoader. What's this FIXME referring to? Is it just an obsolete comment? Can you mention in the ChangeLog why we remove this?
Comment on attachment 353837 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353837&action=review > Source/WebCore/loader/cache/CachedRawResource.h:-32 > -class SubresourceLoader; Can we also briefly mention this change in the ChangeLog too?
Created attachment 353851 [details] Patch
Comment on attachment 353851 [details] Patch Updated commit message after Fred's feedback.
Comment on attachment 353851 [details] Patch Rejecting attachment 353851 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 353851, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9863899
Created attachment 353852 [details] Patch
Comment on attachment 353852 [details] Patch Clearing flags on attachment: 353852 Committed r237797: <https://trac.webkit.org/changeset/237797>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45805544>