Parsing support for text-underline-offset and text-decoration-thickness
Created attachment 353826 [details] Patch
Comment on attachment 353826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review > Source/WebCore/rendering/style/StyleRareInheritedData.h:85 > + TextUnderlineOffset textUnderlineOffset; Why not put into the bitfield? > Source/WebCore/rendering/style/TextDecorationThickness.h:109 > + Type m_type; > + float m_length; 3 bytes of padding here, sadly, and the float is wasted for the "from font" case.
Comment on attachment 353826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review > Source/WebCore/ChangeLog:18 > + We still don't suppor the left and right values on text-underline-position. We should add those eventually. Nit - support
Comment on attachment 353826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review >> Source/WebCore/rendering/style/StyleRareInheritedData.h:85 >> + TextUnderlineOffset textUnderlineOffset; > > Why not put into the bitfield? I don't understand this comment. >> Source/WebCore/rendering/style/TextDecorationThickness.h:109 >> + float m_length; > > 3 bytes of padding here, sadly, and the float is wasted for the "from font" case. Yeah :( Do you have any ideas about how to improve it?
Comment on attachment 353826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review >>> Source/WebCore/rendering/style/StyleRareInheritedData.h:85 >>> + TextUnderlineOffset textUnderlineOffset; >> >> Why not put into the bitfield? > > I don't understand this comment. Oh, it's because TextUnderlineOffset can be auto or a length. text-underline-offset is different from text-underline-position :(
Committed r237835: <https://trac.webkit.org/changeset/237835>
<rdar://problem/45824920>
Committed r237843: <https://trac.webkit.org/changeset/237843>
*** Bug 101931 has been marked as a duplicate of this bug. ***