Bug 191242 - Parsing support for text-underline-offset and text-decoration-thickness
Summary: Parsing support for text-underline-offset and text-decoration-thickness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 101931 (view as bug list)
Depends on:
Blocks: 190774 216092
  Show dependency treegraph
 
Reported: 2018-11-04 20:55 PST by Myles C. Maxfield
Modified: 2022-07-13 11:45 PDT (History)
9 users (show)

See Also:


Attachments
Patch (57.11 KB, patch)
2018-11-04 20:59 PST, Myles C. Maxfield
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-11-04 20:55:01 PST
Parsing support for text-underline-offset and text-decoration-thickness
Comment 1 Myles C. Maxfield 2018-11-04 20:59:33 PST
Created attachment 353826 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-11-05 11:15:14 PST
Comment on attachment 353826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review

> Source/WebCore/rendering/style/StyleRareInheritedData.h:85
> +    TextUnderlineOffset textUnderlineOffset;

Why not put into the bitfield?

> Source/WebCore/rendering/style/TextDecorationThickness.h:109
> +    Type m_type;
> +    float m_length;

3 bytes of padding here, sadly, and the float is wasted for the "from font" case.
Comment 3 Wenson Hsieh 2018-11-05 12:09:33 PST
Comment on attachment 353826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review

> Source/WebCore/ChangeLog:18
> +        We still don't suppor the left and right values on text-underline-position. We should add those eventually.

Nit - support
Comment 4 Myles C. Maxfield 2018-11-05 15:37:49 PST
Comment on attachment 353826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review

>> Source/WebCore/rendering/style/StyleRareInheritedData.h:85
>> +    TextUnderlineOffset textUnderlineOffset;
> 
> Why not put into the bitfield?

I don't understand this comment.

>> Source/WebCore/rendering/style/TextDecorationThickness.h:109
>> +    float m_length;
> 
> 3 bytes of padding here, sadly, and the float is wasted for the "from font" case.

Yeah :( Do you have any ideas about how to improve it?
Comment 5 Myles C. Maxfield 2018-11-05 16:07:01 PST
Comment on attachment 353826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353826&action=review

>>> Source/WebCore/rendering/style/StyleRareInheritedData.h:85
>>> +    TextUnderlineOffset textUnderlineOffset;
>> 
>> Why not put into the bitfield?
> 
> I don't understand this comment.

Oh, it's because TextUnderlineOffset can be auto or a length. text-underline-offset is different from text-underline-position :(
Comment 6 Myles C. Maxfield 2018-11-05 16:11:24 PST
Committed r237835: <https://trac.webkit.org/changeset/237835>
Comment 7 Radar WebKit Bug Importer 2018-11-05 16:12:19 PST
<rdar://problem/45824920>
Comment 8 Myles C. Maxfield 2018-11-05 20:30:54 PST
Committed r237843: <https://trac.webkit.org/changeset/237843>
Comment 9 Brent Fulgham 2022-07-13 11:45:59 PDT
*** Bug 101931 has been marked as a duplicate of this bug. ***