Bug 191231 - [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
Summary: [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-03 19:09 PDT by Wenson Hsieh
Modified: 2018-11-04 13:20 PST (History)
7 users (show)

See Also:

Attachments
Patch (16.12 KB, patch)
2018-11-03 19:51 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix a typo (16.08 KB, patch)
2018-11-03 19:57 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for EWS (16.20 KB, patch)
2018-11-04 12:21 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-11-03 19:09:36 PDT 
SSIA — just cleaning up some duplicated code.
Comment 1 Wenson Hsieh 2018-11-03 19:51:40 PDT 
Created attachment 353791 [details]
Patch
Comment 2 Wenson Hsieh 2018-11-03 19:57:09 PDT 
Created attachment 353793 [details]
Fix a typo
Comment 3 Wenson Hsieh 2018-11-04 12:14:30 PST 
Comment on attachment 353793 [details]
Fix a typo

View in context: https://bugs.webkit.org/attachment.cgi?id=353793&action=review

Thanks for the review!

> Tools/WebKitTestRunner/UIScriptControllerCocoa.mm:146
> +    TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView();
> +    [webView _findString:toWTFString(toWK(string)) options:options maxCount:maxCount];

(Oops, this should be guarded under `WK_API_ENABLED` to fix the 32-bit build)
Comment 4 Wenson Hsieh 2018-11-04 12:21:01 PST 
Created attachment 353806 [details]
Patch for EWS
Comment 5 WebKit Commit Bot 2018-11-04 13:19:51 PST 
Comment on attachment 353806 [details]
Patch for EWS

Clearing flags on attachment: 353806

Committed r237786: <https://trac.webkit.org/changeset/237786>
Comment 6 WebKit Commit Bot 2018-11-04 13:19:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-04 13:20:18 PST 
<rdar://problem/45794523>