Bug 191225 - REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
Summary: REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-02 21:41 PDT by Michael Catanzaro
Modified: 2018-11-05 02:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2018-11-02 22:07 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-11-02 21:41:19 PDT 
r237031 introduced a memory leak breaking /webkit/WebKitWebView/settings:

 /webkit/WebKitWebView/settings:                                     Leaked objects: WebKitSettings(0x55c6218f3160)
FAIL
ERROR:/home/slave/webkitgtk/gtk-linux-64-release/build/Tools/TestWebKitAPI/glib/WebKitGLib/TestMain.h:133:Test::~Test(): assertion failed: (m_watchedObjects.isEmpty())
Comment 1 Michael Catanzaro 2018-11-02 22:07:52 PDT 
Created attachment 353762 [details]
Patch
Comment 2 WebKit Commit Bot 2018-11-05 02:46:45 PST 
Comment on attachment 353762 [details]
Patch

Clearing flags on attachment: 353762

Committed r237795: <https://trac.webkit.org/changeset/237795>
Comment 3 WebKit Commit Bot 2018-11-05 02:46:47 PST 
All reviewed patches have been landed.  Closing bug.