Bug 191224 – [LFC][BFC] Resolve percentage height values.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

10.5 Content height: the 'height' property

The percentage is calculated with respect to the height of the generated box's containing block. 
If the height of the containing block is not specified explicitly (i.e., it depends on content height), 
and this element is not absolutely positioned, the used height is calculated as if 'auto' was specified. 


https://www.w3.org/TR/CSS22/visudet.html#propdef-height

[alan]

Created attachment 353761 [details]
Patch

[EWS Watchlist]

Comment on attachment 353761 [details]
Patch

Attachment 353761 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9841484

New failing tests:
fast/block/basic/height-percentage-simple.html

[EWS Watchlist]

Created attachment 353767 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Antti Koivisto]

Comment on attachment 353761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353761&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:60
> +enum class HeightType { Min, Max };

How about adding type Logical and using this without optional?

[alan]

Comment on attachment 353761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353761&action=review

>> Source/WebCore/layout/FormattingContextGeometry.cpp:60
>> +enum class HeightType { Min, Max };
> 
> How about adding type Logical and using this without optional?

I had it exactly like that in my original patch but I couldn't come up with a great name for the 3rd type (I called it Normal, since Min and Max are also logical)

[alan]

Committed r237775: <https://trac.webkit.org/changeset/237775>

[Radar WebKit Bug Importer]

<rdar://problem/45785401>