Bug 191223 - [WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
Summary: [WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-02 19:49 PDT by Michael Catanzaro
Modified: 2018-11-05 00:03 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2018-11-02 22:10 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (1.42 KB, patch)
2018-11-02 22:19 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-11-02 19:49:49 PDT
Since we need to support old versions of GStreamer, and that requires disabling ENABLE_MEDIA_SOURCE, we should expose it as a public option. It's pretty weird to tell users that they need to disable a secret hidden option in order to build WebKit.
Comment 1 Michael Catanzaro 2018-11-02 22:10:33 PDT
Created attachment 353763 [details]
Patch
Comment 2 Michael Catanzaro 2018-11-02 22:19:16 PDT
Created attachment 353764 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2018-11-04 23:38:34 PST
Comment on attachment 353764 [details]
Patch

IMHO, what was weird was that this was private in the first place.
Comment 4 WebKit Commit Bot 2018-11-05 00:03:37 PST
Comment on attachment 353764 [details]
Patch

Clearing flags on attachment: 353764

Committed r237791: <https://trac.webkit.org/changeset/237791>
Comment 5 WebKit Commit Bot 2018-11-05 00:03:39 PST
All reviewed patches have been landed.  Closing bug.