Bug 191211 - REGRESSION (r237735?): [ MacOS WK2 ] Layout Test http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html is a flaky timeout
Summary: REGRESSION (r237735?): [ MacOS WK2 ] Layout Test http/tests/resourceLoadStati...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
Keywords: InRadar
Depends on:
Reported: 2018-11-02 14:27 PDT by Truitt Savell
Modified: 2019-01-15 10:55 PST (History)
8 users (show)

See Also:

Patch (4.82 KB, patch)
2019-01-14 16:16 PST, John Wilander
no flags Details | Formatted Diff | Diff
Patch for landing (4.82 KB, patch)
2019-01-14 17:13 PST, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2018-11-02 14:27:51 PDT
The following layout test is flaky on MacOS WK2


Probable cause:

This test has been slightly flakey for a while, within the last few revisions it has become significantly flakey. r237735 is around where this increased flakiness began. 

Flakiness Dashboard:

Comment 1 Truitt Savell 2018-11-02 15:39:04 PDT
looks like this issue came from https://trac.webkit.org/changeset/237735/webkit
Comment 2 Chris Dumez 2018-11-02 15:48:44 PDT
http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html is indeed impacted by r237735 as the test navigates from origin A to origin B and then back to A. We are now using the same process both both loads of origin A instead of 2 separate processes.

That said, my change only impacted the timing of things by reusing an existing process instead of spinning up a fresh new one. 

The test was already flaky so patches impacting timing can definitely make flaky tests more or less flaky. That said, the issue is not with r237735 but rather with the test being flaky in the first place.
Comment 3 Radar WebKit Bug Importer 2018-11-05 13:44:51 PST
Comment 4 John Wilander 2019-01-14 16:16:54 PST
Created attachment 359094 [details]
Comment 5 John Wilander 2019-01-14 16:17:37 PST
Uploaded an attempt to address the flakiness.
Comment 6 John Wilander 2019-01-14 16:48:22 PST
mac-wk2 failing tests are unrelated.
Comment 7 John Wilander 2019-01-14 17:13:45 PST
Created attachment 359100 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2019-01-14 17:51:20 PST
Comment on attachment 359100 [details]
Patch for landing

Clearing flags on attachment: 359100

Committed r239966: <https://trac.webkit.org/changeset/239966>
Comment 9 WebKit Commit Bot 2019-01-14 17:51:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 John Wilander 2019-01-15 10:55:20 PST
I just had a look at the flakiness dashboard and the test has improved significantly after the change.