Bug 191207 - REGRESSION: [ MacOS iOS ] Layout Test http/wpt/resource-timing/rt-revalidate-requests.html is flaky timeout
Summary: REGRESSION: [ MacOS iOS ] Layout Test http/wpt/resource-timing/rt-revalidate-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 171511 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-11-02 13:53 PDT by Truitt Savell
Modified: 2018-12-12 17:23 PST (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (18.17 KB, patch)
2018-12-12 15:11 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2018-11-02 13:53:59 PDT 
The following layout test is flaky on MacOS and iOS

http/wpt/resource-timing/rt-revalidate-requests.html

Probable cause:

Test is a flakey failure already marked as flakey from webkit.org/b/171511. Recently it has become a flakey Timeout, we should be able to regress this. 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fresource-timing%2Frt-revalidate-requests.html
Comment 1 Truitt Savell 2018-11-02 15:39:21 PDT 
looks like this issue came from https://trac.webkit.org/changeset/237735/webkit
Comment 2 Chris Dumez 2018-11-02 15:45:38 PDT 
(In reply to Truitt Savell from comment #1)
> looks like this issue came from
> https://trac.webkit.org/changeset/237735/webkit

I do not think this is possible. I have verified and this test does not process swap so r237735 is a no-op in the context of this test and cannot even impact the timing.

However, from running http/wpt/resource-timing/rt-revalidate-requests.html, I can say that it is very slow, which may be why it is timing out on bots.
Comment 3 Radar WebKit Bug Importer 2018-11-05 13:50:37 PST 
<rdar://problem/45818891>
Comment 4 Joseph Pecoraro 2018-12-10 11:54:25 PST 
Looking at the test history it doesn't look like failures / timeouts are any more common recently (at least in however far back the flakiness dashboard goes). I can probably split this test up into a few tests and see if that helps.
Comment 5 Joseph Pecoraro 2018-12-12 15:11:52 PST 
Created attachment 357173 [details]
[PATCH] Proposed Fix
Comment 6 Joseph Pecoraro 2018-12-12 15:12:41 PST 
*** Bug 171511 has been marked as a duplicate of this bug. ***
Comment 7 EWS Watchlist 2018-12-12 15:13:30 PST 
Attachment 357173 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Devin Rousso 2018-12-12 17:12:34 PST 
Comment on attachment 357173 [details]
[PATCH] Proposed Fix

rs=me

Maybe we should have better names than "rt-revalidate-requests-1.html", like "rt-revalidate-requests-sameorigin.html"...
Comment 9 WebKit Commit Bot 2018-12-12 17:23:12 PST 
Comment on attachment 357173 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 357173

Committed r239138: <https://trac.webkit.org/changeset/239138>
Comment 10 WebKit Commit Bot 2018-12-12 17:23:14 PST 
All reviewed patches have been landed.  Closing bug.