Bug 191207 – REGRESSION: [ MacOS iOS ] Layout Test http/wpt/resource-timing/rt-revalidate-requests.html is flaky timeout

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Truitt Savell]

The following layout test is flaky on MacOS and iOS

http/wpt/resource-timing/rt-revalidate-requests.html

Probable cause:

Test is a flakey failure already marked as flakey from webkit.org/b/171511. Recently it has become a flakey Timeout, we should be able to regress this. 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fresource-timing%2Frt-revalidate-requests.html

[Truitt Savell]

looks like this issue came from https://trac.webkit.org/changeset/237735/webkit

[Chris Dumez]

(In reply to Truitt Savell from comment #1)
> looks like this issue came from
> https://trac.webkit.org/changeset/237735/webkit

I do not think this is possible. I have verified and this test does not process swap so r237735 is a no-op in the context of this test and cannot even impact the timing.

However, from running http/wpt/resource-timing/rt-revalidate-requests.html, I can say that it is very slow, which may be why it is timing out on bots.

[Radar WebKit Bug Importer]

<rdar://problem/45818891>

[Joseph Pecoraro]

Looking at the test history it doesn't look like failures / timeouts are any more common recently (at least in however far back the flakiness dashboard goes). I can probably split this test up into a few tests and see if that helps.

[Joseph Pecoraro]

Created attachment 357173 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

*** Bug 171511 has been marked as a duplicate of this bug. ***

[EWS Watchlist]

Attachment 357173 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Devin Rousso]

Comment on attachment 357173 [details]
[PATCH] Proposed Fix

rs=me

Maybe we should have better names than "rt-revalidate-requests-1.html", like "rt-revalidate-requests-sameorigin.html"...

[WebKit Commit Bot]

Comment on attachment 357173 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 357173

Committed r239138: <https://trac.webkit.org/changeset/239138>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.