Bug 191205 - Improve the SVG blog post icon approach
Summary: Improve the SVG blog post icon approach
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
Keywords: InRadar
Depends on:
Reported: 2018-11-02 13:01 PDT by Jon Davis
Modified: 2018-11-02 14:44 PDT (History)
4 users (show)

See Also:

Patch (54.21 KB, patch)
2018-11-02 13:53 PDT, Jon Davis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2018-11-02 13:01:27 PDT
The current SVG icon approach for blog posts uses an SVG sprite sheet that is positioned with percentage based background-position-y. It makes it very hard to add new icons. We need a new approach that makes it easy to specify add new icons and easily fallback to a default icon.
Comment 1 Jon Davis 2018-11-02 13:53:21 PDT
Created attachment 353726 [details]
Comment 2 Timothy Hatcher 2018-11-02 14:02:58 PDT
Comment on attachment 353726 [details]

Comment 3 WebKit Commit Bot 2018-11-02 14:43:49 PDT
Comment on attachment 353726 [details]

Clearing flags on attachment: 353726

Committed r237752: <https://trac.webkit.org/changeset/237752>
Comment 4 WebKit Commit Bot 2018-11-02 14:43:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-02 14:44:18 PDT