RESOLVED FIXED 191205
Improve the SVG blog post icon approach 
https://bugs.webkit.org/show_bug.cgi?id=191205
Summary Improve the SVG blog post icon approach
Jon Davis
Reported 2018-11-02 13:01:27 PDT
The current SVG icon approach for blog posts uses an SVG sprite sheet that is positioned with percentage based background-position-y. It makes it very hard to add new icons. We need a new approach that makes it easy to specify add new icons and easily fallback to a default icon.
Attachments
Patch (54.21 KB, patch)
2018-11-02 13:53 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2018-11-02 13:53:21 PDT
Created attachment 353726 [details] Patch
Timothy Hatcher
Comment 2 2018-11-02 14:02:58 PDT
Comment on attachment 353726 [details] Patch Nice!
WebKit Commit Bot
Comment 3 2018-11-02 14:43:49 PDT
Comment on attachment 353726 [details] Patch Clearing flags on attachment: 353726 Committed r237752: <https://trac.webkit.org/changeset/237752>
WebKit Commit Bot
Comment 4 2018-11-02 14:43:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-11-02 14:44:18 PDT
<rdar://problem/45773768>
Note You need to log in before you can comment on or make changes to this bug.