Bug 191192 - Add support for sender/receiver getCapabilities
Summary: Add support for sender/receiver getCapabilities
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-02 06:53 PDT by youenn fablet
Modified: 2018-11-06 20:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (28.51 KB, patch)
2018-11-02 06:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (32.42 KB, patch)
2018-11-03 19:05 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (35.37 KB, patch)
2018-11-06 18:52 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-11-02 06:53:35 PDT 
Add support for sender/receiver getCapabilities
Comment 1 youenn fablet 2018-11-02 06:58:46 PDT 
Created attachment 353694 [details]
Patch
Comment 2 Eric Carlson 2018-11-02 10:04:16 PDT 
Comment on attachment 353694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353694&action=review

> Source/WebCore/ChangeLog:9
> +        Add corresponding IDL and plumbery down to libwebrtc peer connection factory.

Nit: s/plumbery/plumbing/

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:64
> +    return { };

Nit: ASSERT_NOT_REACHED?

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:69
> +    return { };

Ditto.

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:302
> +    return static_cast<uint32_t>(*numChannels);

safeCast<uint32_t>?

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:311
> +        capabilities.codecs.uncheckedAppend(RTCRtpCapabilities::CodecCapability { fromStdString(codec.mime_type()), static_cast<uint32_t>(codec.clock_rate ? *codec.clock_rate : 0), toChannels(codec.num_channels), { } });

Ditto.
Comment 3 youenn fablet 2018-11-03 19:05:49 PDT 
Created attachment 353789 [details]
Patch
Comment 4 Eric Carlson 2018-11-04 06:20:18 PST 
Comment on attachment 353789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353789&action=review

> Source/WebCore/ChangeLog:9
> +        Add corresponding IDL and plumbery down to libwebrtc peer connection factory.

Nit: s/plumbery/plumbing/

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:64
> +    return { };

Nit: ASSERT_NOT_REACHED()?

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:69
> +    return { };

Ditto.

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:302
> +    return static_cast<uint32_t>(*numChannels);

Nit: safeCast<uint32_t>?

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:310
> +    for (auto& codec : rtpCapabilities.codecs)

Ditto.
Comment 5 youenn fablet 2018-11-06 18:52:44 PST 
Created attachment 354044 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-11-06 20:01:58 PST 
Comment on attachment 354044 [details]
Patch for landing

Clearing flags on attachment: 354044

Committed r237911: <https://trac.webkit.org/changeset/237911>
Comment 7 WebKit Commit Bot 2018-11-06 20:02:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-11-06 20:03:29 PST 
<rdar://problem/45864599>