Bug 191192 – Add support for sender/receiver getCapabilities

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add support for sender/receiver getCapabilities

[youenn fablet]

Created attachment 353694 [details]
Patch

[Eric Carlson]

Comment on attachment 353694 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353694&action=review

> Source/WebCore/ChangeLog:9
> +        Add corresponding IDL and plumbery down to libwebrtc peer connection factory.

Nit: s/plumbery/plumbing/

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:64
> +    return { };

Nit: ASSERT_NOT_REACHED?

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:69
> +    return { };

Ditto.

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:302
> +    return static_cast<uint32_t>(*numChannels);

safeCast<uint32_t>?

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:311
> +        capabilities.codecs.uncheckedAppend(RTCRtpCapabilities::CodecCapability { fromStdString(codec.mime_type()), static_cast<uint32_t>(codec.clock_rate ? *codec.clock_rate : 0), toChannels(codec.num_channels), { } });

Ditto.

[youenn fablet]

Created attachment 353789 [details]
Patch

[Eric Carlson]

Comment on attachment 353789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353789&action=review

> Source/WebCore/ChangeLog:9
> +        Add corresponding IDL and plumbery down to libwebrtc peer connection factory.

Nit: s/plumbery/plumbing/

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:64
> +    return { };

Nit: ASSERT_NOT_REACHED()?

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:69
> +    return { };

Ditto.

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:302
> +    return static_cast<uint32_t>(*numChannels);

Nit: safeCast<uint32_t>?

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:310
> +    for (auto& codec : rtpCapabilities.codecs)

Ditto.

[youenn fablet]

Created attachment 354044 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 354044 [details]
Patch for landing

Clearing flags on attachment: 354044

Committed r237911: <https://trac.webkit.org/changeset/237911>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45864599>