Bug 191190 - Enable LLInt on ARMv7/Linux
Summary: Enable LLInt on ARMv7/Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 191163
  Show dependency tree / graph
 
Reported: 2018-11-02 06:31 PDT by Dominik Inführ
Modified: 2018-11-05 08:08 PST (History)
10 users (show)

See Also:

Attachments
Patch (14.71 KB, patch)
2018-11-02 06:43 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Patch (14.70 KB, patch)
2018-11-02 06:49 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Patch (14.70 KB, patch)
2018-11-02 08:20 PDT, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Patch (14.97 KB, patch)
2018-11-05 00:13 PST, Dominik Inführ 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2018-11-02 06:31:06 PDT 
Enable LLInt on ARMv7/Linux
Comment 1 Dominik Inführ 2018-11-02 06:43:25 PDT 
Created attachment 353691 [details]
Patch
Comment 2 Dominik Inführ 2018-11-02 06:49:09 PDT 
Created attachment 353692 [details]
Patch
Comment 3 Dominik Inführ 2018-11-02 08:20:53 PDT 
Created attachment 353704 [details]
Patch
Comment 4 Yusuke Suzuki 2018-11-02 19:44:21 PDT 
Comment on attachment 353704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353704&action=review

r=me

> Source/JavaScriptCore/jit/GPRInfo.h:564
> +    static const GPRReg regCS0 = ARMRegisters::r11;

Put `regCS0` definition just after `regTx` temporary registers.

> Source/JavaScriptCore/offlineasm/arm.rb:137
> +            "r11"

Update the document in arm.rb's header.
Comment 5 Dominik Inführ 2018-11-05 00:13:25 PST 
Created attachment 353833 [details]
Patch
Comment 6 EWS Watchlist 2018-11-05 01:47:11 PST 
Comment on attachment 353833 [details]
Patch

Attachment 353833 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/9861865

New failing tests:
stress/regexp-compile-oom.js.dfg-maximal-flush-validate-no-cjit
stress/const-semantics.js.dfg-eager
apiTests
Comment 7 Dominik Inführ 2018-11-05 07:42:28 PST 
Test failures not related to this patch.
Comment 8 WebKit Commit Bot 2018-11-05 08:07:47 PST 
Comment on attachment 353833 [details]
Patch

Clearing flags on attachment: 353833

Committed r237803: <https://trac.webkit.org/changeset/237803>
Comment 9 WebKit Commit Bot 2018-11-05 08:07:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-11-05 08:08:26 PST 
<rdar://problem/45807492>