Bug 191180 - [iOS] Changing view scale sometimes does not zoom the page to the new initial scale, when the page is at initial scale
Summary: [iOS] Changing view scale sometimes does not zoom the page to the new initial...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-01 20:50 PDT by Wenson Hsieh
Modified: 2018-11-02 11:10 PDT (History)
7 users (show)

See Also:


Attachments
Patch (13.22 KB, patch)
2018-11-01 21:48 PDT, Wenson Hsieh
simon.fraser: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.87 MB, application/zip)
2018-11-01 22:59 PDT, EWS Watchlist
no flags Details
Patch for landing (13.47 KB, patch)
2018-11-02 10:32 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-11-01 20:50:33 PDT
Example: <meta name="viewport" content="width=device-width, initial-scale=0.94, minimum-scale=0.94">

Expected minimum and initial scales: 0.94
Observed minimum and initial scales: 0.9415

(tested on iPhone SE simulator)
Comment 1 Wenson Hsieh 2018-11-01 20:51:35 PDT
<rdar://problem/45744786>
Comment 2 Wenson Hsieh 2018-11-01 21:48:32 PDT
Created attachment 353679 [details]
Patch
Comment 3 EWS Watchlist 2018-11-01 22:59:17 PDT
Comment on attachment 353679 [details]
Patch

Attachment 353679 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9826500

New failing tests:
http/tests/security/anchor-download-block-crossorigin.html
Comment 4 EWS Watchlist 2018-11-01 22:59:19 PDT Comment hidden (obsolete)
Comment 5 Simon Fraser (smfr) 2018-11-02 09:57:26 PDT
Comment on attachment 353679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353679&action=review

> Source/WebCore/ChangeLog:3
> +        [iOS] Viewport tag with minimum-scale sometimes causes the minimum scale to be close to the specified value

This should say "close to but not exactly" or something.

This also doesn't seem to describe the real user-facing impact of the bug.
Comment 6 Wenson Hsieh 2018-11-02 10:13:33 PDT
Comment on attachment 353679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353679&action=review

>> Source/WebCore/ChangeLog:3
>> +        [iOS] Viewport tag with minimum-scale sometimes causes the minimum scale to be close to the specified value
> 
> This should say "close to but not exactly" or something.
> 
> This also doesn't seem to describe the real user-facing impact of the bug.

Sounds good — changed the title to reflect the real user-facing impact.
Comment 7 Wenson Hsieh 2018-11-02 10:32:28 PDT
Created attachment 353710 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-11-02 11:10:32 PDT
Comment on attachment 353710 [details]
Patch for landing

Clearing flags on attachment: 353710

Committed r237743: <https://trac.webkit.org/changeset/237743>