Bug 191174 – Web Inspector: Network: remove unnecessary media event tracking

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

There's no reason to show event "bubbles" for events that have nothing to do with network activity (e.g. "volumechanged").

[Devin Rousso]

Created attachment 353652 [details]
Patch

[Devin Rousso]

Created attachment 353653 [details]
[Image] After Patch is applied

[Joseph Pecoraro]

Comment on attachment 353652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353652&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:91
> +.network-table .data-container .cell.name .range {
> +    font-style: italic;
> +}

I'm not sure I like the italics here. For tree elements we typically put a subtitle in a lighter gray color and not italicize. I'm not sure what would be best we can experiment.

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:1103
> +        setTimeout(() => {
> +            if (this._waterfallPopover)
> +                this._waterfallPopover.resize();
> +        });

Why in a setTimeout? Should this be a debounce?

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:1929
> +        this._handleMousedownWaterfall(nodeEntry, popoverContentElement, (cell) => {
> +            let domEventElement = nodeEntry.domEventElements.get(domEvents[0]);

It is weird to name this a `getTargetElementFunction` when it may also change the contents of the popover. I see why its happening though. Maybe a more generic `resizeAndPositionHandler`/`repositionAndResizeHandler` might be better?

[Devin Rousso]

Comment on attachment 353652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353652&action=review

>> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:1103
>> +        });
> 
> Why in a setTimeout? Should this be a debounce?

I want to call this function after the `WI.Table` has finished `layout`, as it's at that point that the elements are in the DOM.  I think the better approach is to introduce another base function to `WI.View` that gets called once a subtree has finished `layout`.

[Devin Rousso]

Created attachment 353661 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 353661 [details]
Patch

Clearing flags on attachment: 353661

Committed r237708: <https://trac.webkit.org/changeset/237708>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45748484>