Bug 191173 - Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
Summary: Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.mod...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-01 15:02 PDT by Nikita Vasilyev
Modified: 2018-11-01 16:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2018-11-01 15:33 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-11-01 15:02:41 PDT
Steps:
1. Reload Web Inspector

This uncaught exceptions *may* happen:

TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
 selected @ ScopeBarItem.js:87:67
 _populate @ ScopeBar.js:138:34
 ScopeBar @ ScopeBar.js:40:23
 LogContentView @ LogContentView.js:96:53
 createFromRepresentedObject @ ContentView.js:156:41
 contentViewForRepresentedObject @ ContentView.js:205:72
 contentLoaded @ Main.js:256:81 ? @ [native code]

TypeError: undefined is not an object (evaluating 'this.modifierKeys.metaKey') (at Main.js:1458:45)
 _updateModifierKeys @ Main.js:1458:45
 _mouseMoved @ Main.js:1488:29 ? @ [native code]
Comment 1 Nikita Vasilyev 2018-11-01 15:33:46 PDT
Created attachment 353651 [details]
Patch

This was likely a recent regression. Regardless of that, it was odd to have `WI.modifierKeys` initialized somewhere in the middle of WI.contentLoaded — it should come before that.
Comment 2 Devin Rousso 2018-11-01 15:38:58 PDT
r=me
Comment 3 WebKit Commit Bot 2018-11-01 16:24:24 PDT
Comment on attachment 353651 [details]
Patch

Clearing flags on attachment: 353651

Committed r237705: <https://trac.webkit.org/changeset/237705>
Comment 4 WebKit Commit Bot 2018-11-01 16:24:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-01 16:25:20 PDT
<rdar://problem/45746695>