Bug 191172 - Remove ENABLE_OPENCL fully
Summary: Remove ENABLE_OPENCL fully
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-01 14:56 PDT by Don Olmstead
Modified: 2018-11-04 18:15 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.29 KB, patch)
2018-11-02 07:17 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (2.43 KB, patch)
2018-11-04 05:48 PST, Rob Buis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-11-01 14:56:38 PDT
There's still some ENABLE(OPENCL) code hanging out in the repository.
Comment 1 Rob Buis 2018-11-02 07:17:52 PDT
Created attachment 353697 [details]
Patch
Comment 2 Yusuke Suzuki 2018-11-02 07:24:40 PDT
Comment on attachment 353697 [details]
Patch

r=me. Nobody is using ENABLE(OPENCL). And we do not have implementations.
Comment 3 WebKit Commit Bot 2018-11-02 08:39:59 PDT
Comment on attachment 353697 [details]
Patch

Clearing flags on attachment: 353697

Committed r237732: <https://trac.webkit.org/changeset/237732>
Comment 4 WebKit Commit Bot 2018-11-02 08:40:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-02 08:40:21 PDT
<rdar://problem/45762732>
Comment 6 Don Olmstead 2018-11-02 10:48:03 PDT
Comment on attachment 353697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353697&action=review

Beat me to the patch :)

Anyways I didn't throw it up because of the applyAll still being there. Seems like that was just there for OPENCL support so it should probably go as well.

> Source/WebCore/platform/graphics/filters/FilterEffect.h:96
>      inline void applyAll() { apply(); }

Should this still be here?
Comment 7 Rob Buis 2018-11-02 10:50:57 PDT
Hi Don, right I took the gamble since you did not assign to yourself :)
The applyAll seems not needed, if you want to do a patch feel free, otherwise I can do it tomorrow.
Comment 8 Rob Buis 2018-11-04 05:48:06 PST
Reopening to attach new patch.
Comment 9 Rob Buis 2018-11-04 05:48:09 PST
Created attachment 353802 [details]
Patch
Comment 10 Yusuke Suzuki 2018-11-04 17:51:05 PST
Comment on attachment 353802 [details]
Patch

r=me
Comment 11 WebKit Commit Bot 2018-11-04 18:15:56 PST
Comment on attachment 353802 [details]
Patch

Clearing flags on attachment: 353802

Committed r237787: <https://trac.webkit.org/changeset/237787>
Comment 12 WebKit Commit Bot 2018-11-04 18:15:58 PST
All reviewed patches have been landed.  Closing bug.