Bug 191170 - build-jsc --wincairo should update WinCairo libraries
Summary: build-jsc --wincairo should update WinCairo libraries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-01 14:47 PDT by Ross Kirsling
Modified: 2018-11-01 19:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.07 KB, patch)
2018-11-01 14:48 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-11-01 14:47:24 PDT 
build-jsc --wincairo should update WinCairo libraries
Comment 1 Ross Kirsling 2018-11-01 14:48:02 PDT 
Created attachment 353646 [details]
Patch
Comment 2 Ross Kirsling 2018-11-01 14:49:48 PDT 
We set up `build-jsc --jsc-only` to update WinCairo libs when on Windows, but `build-jsc --wincairo` isn't currently doing so.
(The latter is actually more useful because it's compatible with `build-webkit --wincairo`.)
Comment 3 WebKit Commit Bot 2018-11-01 19:04:32 PDT 
Comment on attachment 353646 [details]
Patch

Clearing flags on attachment: 353646

Committed r237716: <https://trac.webkit.org/changeset/237716>
Comment 4 WebKit Commit Bot 2018-11-01 19:04:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-01 19:05:22 PDT 
<rdar://problem/45750602>