Bug 191165 - Web Inspector: Styles: inline swatches don't work when Multiple Properties Selection is enabled
Summary: Web Inspector: Styles: inline swatches don't work when Multiple Properties Se...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-01 12:24 PDT by Nikita Vasilyev
Modified: 2018-11-12 20:43 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2018-11-10 18:33 PST, Nikita Vasilyev 		hi: review-
Details | Formatted Diff | Diff
[Animated GIF] With patch applied (131.26 KB, image/gif)
2018-11-10 18:33 PST, Nikita Vasilyev 		no flags Details
Patch (4.35 KB, patch)
2018-11-11 20:02 PST, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-11-01 12:24:30 PDT 
Clicking on an inline swatch starts editing the property value instead of showing a popover (such as a color picker).
Comment 1 Radar WebKit Bug Importer 2018-11-01 12:24:49 PDT 
<rdar://problem/45737972>
Comment 2 Nikita Vasilyev 2018-11-10 18:33:12 PST 
Created attachment 354489 [details]
Patch

This was surprisingly tricky. I learned that "mouseup" always fires before "click".
Comment 3 Nikita Vasilyev 2018-11-10 18:33:41 PST 
Created attachment 354490 [details]
[Animated GIF] With patch applied
Comment 4 Devin Rousso 2018-11-11 17:27:01 PST 
Comment on attachment 354489 [details]
Patch

r-, I am unable to click again after I've started editing (e.g. to move the cursor), as it tries to restart editing
Comment 5 Nikita Vasilyev 2018-11-11 19:52:32 PST 
(In reply to Devin Rousso from comment #4)
> Comment on attachment 354489 [details]
> Patch
> 
> r-, I am unable to click again after I've started editing (e.g. to move the
> cursor), as it tries to restart editing

This is actually a bug that wasn't introduced by this patch. Regardless, I can fix it here.
Comment 6 Nikita Vasilyev 2018-11-11 20:02:19 PST 
Created attachment 354528 [details]
Patch
Comment 7 Devin Rousso 2018-11-12 20:15:16 PST 
Comment on attachment 354528 [details]
Patch

r=me, nice fix :)
Comment 8 WebKit Commit Bot 2018-11-12 20:43:49 PST 
Comment on attachment 354528 [details]
Patch

Clearing flags on attachment: 354528

Committed r238120: <https://trac.webkit.org/changeset/238120>
Comment 9 WebKit Commit Bot 2018-11-12 20:43:51 PST 
All reviewed patches have been landed.  Closing bug.