RESOLVED INVALID 191150
[WebAuthN] Remove CBOR prefix 
https://bugs.webkit.org/show_bug.cgi?id=191150
Summary [WebAuthN] Remove CBOR prefix
Rob Buis
Reported 2018-11-01 07:05:27 PDT
This prefix is kind of superfluous because of the CBOR namespace. Chromium change: https://chromium-review.googlesource.com/c/1289509
Attachments
Patch (175.61 KB, patch)
2018-11-01 07:08 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (175.79 KB, patch)
2018-11-01 08:13 PDT, Rob Buis 		jiewen_tan: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-11-01 07:08:42 PDT
Created attachment 353595 [details] Patch
EWS Watchlist
Comment 2 2018-11-01 07:12:15 PDT
Attachment 353595 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:151: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:154: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:155: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:156: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:157: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:158: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:159: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:160: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:161: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:162: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:163: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 12 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 3 2018-11-01 08:13:40 PDT
Created attachment 353601 [details] Patch
EWS Watchlist
Comment 4 2018-11-01 08:16:41 PDT
Attachment 353601 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:151: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:154: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:155: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:156: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:157: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:158: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:159: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:160: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:161: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:162: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/Modules/webauthn/cbor/Value.h:163: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 11 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 5 2018-11-01 09:30:54 PDT
Comment on attachment 353601 [details] Patch The patch is optional but I think nice to keep in sync with chromium. The two failing buildbots are unrelated and the style error was there before my patch.
Jiewen Tan
Comment 6 2018-11-01 11:39:22 PDT
Comment on attachment 353601 [details] Patch I am not convinced that it is necessary to do this renaming.
Rob Buis
Comment 7 2018-11-01 13:17:39 PDT
Your call, but I think not having this makes future cherry-picks harder.
Jiewen Tan
Comment 8 2018-11-01 14:06:30 PDT
(In reply to Rob Buis from comment #7) > Your call, but I think not having this makes future cherry-picks harder. It is hard anyway as coding styles between Chromium and WebKit diverges hugely nowadays.
Note You need to log in before you can comment on or make changes to this bug.