191137 – Web Inspector: Move a few remaining global WI settings to WI.settings

Bug 191137 - Web Inspector: Move a few remaining global WI settings to WI.settings

Summary: Web Inspector: Move a few remaining global WI settings to WI.settings

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Joseph Pecoraro

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-10-31 15:16 PDT by Joseph Pecoraro
Modified:	2018-10-31 17:38 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (38.47 KB, patch) 2018-10-31 15:22 PDT, Joseph Pecoraro	ews-watchlist: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews100 for mac-sierra (2.68 MB, application/zip) 2018-10-31 16:03 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.84 MB, application/zip) 2018-10-31 16:17 PDT, EWS Watchlist	no flags	Details
[PATCH] Proposed Fix (38.53 KB, patch) 2018-10-31 16:21 PDT, Joseph Pecoraro	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joseph Pecoraro 2018-10-31 15:16:53 PDT

Move a few remaining global WI settings to WI.settings

This was a review comment elsewhere.

Comment 1 Joseph Pecoraro 2018-10-31 15:22:04 PDT

Created attachment 353538 [details]
[PATCH] Proposed Fix

Comment 2 EWS Watchlist 2018-10-31 16:03:50 PDT Comment hidden (obsolete)

Comment on attachment 353538 [details]
[PATCH] Proposed Fix

Attachment 353538 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9801674

New failing tests:
inspector/dom/shadow-and-non-shadow-children.html
inspector/css/pseudo-element-matches.html

Comment 3 EWS Watchlist 2018-10-31 16:03:52 PDT Comment hidden (obsolete)

Created attachment 353543 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 4 EWS Watchlist 2018-10-31 16:17:35 PDT Comment hidden (obsolete)

Comment on attachment 353538 [details]
[PATCH] Proposed Fix

Attachment 353538 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9801770

New failing tests:
inspector/dom/shadow-and-non-shadow-children.html
inspector/css/pseudo-element-matches.html

Comment 5 EWS Watchlist 2018-10-31 16:17:43 PDT Comment hidden (obsolete)

Created attachment 353545 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 6 Joseph Pecoraro 2018-10-31 16:19:09 PDT

Comment on attachment 353538 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=353538&action=review

> Source/WebInspectorUI/UserInterface/Test/Test.js:-71
> -    // Global settings.
> -    this.showShadowDOMSetting = new WI.Setting("show-shadow-dom", true);

Oh interesting this is `true` in tests. I'll update this.

Comment 7 Joseph Pecoraro 2018-10-31 16:21:44 PDT

Created attachment 353548 [details]
[PATCH] Proposed Fix

Comment 8 BJ Burg 2018-10-31 16:30:38 PDT

Comment on attachment 353548 [details]
[PATCH] Proposed Fix

r=mews

Comment 9 WebKit Commit Bot 2018-10-31 17:37:48 PDT

Comment on attachment 353548 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 353548

Committed r237661: <https://trac.webkit.org/changeset/237661>

Comment 10 WebKit Commit Bot 2018-10-31 17:37:49 PDT

All reviewed patches have been landed.  Closing bug.

Comment 11 Radar WebKit Bug Importer 2018-10-31 17:38:29 PDT

<rdar://problem/45717720>