Bug 191137 – Web Inspector: Move a few remaining global WI settings to WI.settings

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Move a few remaining global WI settings to WI.settings

This was a review comment elsewhere.

[Joseph Pecoraro]

Created attachment 353538 [details]
[PATCH] Proposed Fix

[EWS Watchlist]

Comment on attachment 353538 [details]
[PATCH] Proposed Fix

Attachment 353538 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9801674

New failing tests:
inspector/dom/shadow-and-non-shadow-children.html
inspector/css/pseudo-element-matches.html

[EWS Watchlist]

Created attachment 353543 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 353538 [details]
[PATCH] Proposed Fix

Attachment 353538 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9801770

New failing tests:
inspector/dom/shadow-and-non-shadow-children.html
inspector/css/pseudo-element-matches.html

[EWS Watchlist]

Created attachment 353545 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Joseph Pecoraro]

Comment on attachment 353538 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=353538&action=review

> Source/WebInspectorUI/UserInterface/Test/Test.js:-71
> -    // Global settings.
> -    this.showShadowDOMSetting = new WI.Setting("show-shadow-dom", true);

Oh interesting this is `true` in tests. I'll update this.

[Joseph Pecoraro]

Created attachment 353548 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 353548 [details]
[PATCH] Proposed Fix

r=mews

[WebKit Commit Bot]

Comment on attachment 353548 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 353548

Committed r237661: <https://trac.webkit.org/changeset/237661>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45717720>