Bug 191115 - Adjust inlining threshold for new bytecode format
Summary: Adjust inlining threshold for new bytecode format
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-31 08:27 PDT by Tadeu Zagallo
Modified: 2018-10-31 11:45 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2018-10-31 08:29 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Patch for landing (1.65 KB, patch)
2018-10-31 11:07 PDT, Tadeu Zagallo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tadeu Zagallo 2018-10-31 08:27:58 PDT 
The new format changed the number of operands for many opcodes, which changed inlining decisions and impacted performance negatively.
Comment 1 Tadeu Zagallo 2018-10-31 08:29:53 PDT 
Created attachment 353494 [details]
Patch
Comment 2 Saam Barati 2018-10-31 11:00:02 PDT 
Comment on attachment 353494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353494&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        The new format changed the number of operands for many opcodes, which

I think it's worth noting that you often made it so we had fewer operands, not more.

> Source/JavaScriptCore/runtime/Options.h:306
> +    v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 120, Normal, nullptr) \

I wonder if this obviates that test you just added.
Comment 3 Tadeu Zagallo 2018-10-31 11:07:10 PDT 
Created attachment 353507 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-10-31 11:44:20 PDT 
Comment on attachment 353507 [details]
Patch for landing

Clearing flags on attachment: 353507

Committed r237645: <https://trac.webkit.org/changeset/237645>
Comment 5 WebKit Commit Bot 2018-10-31 11:44:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-31 11:45:28 PDT 
<rdar://problem/45707063>