[GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
Created attachment 353485 [details] Patch
Comment on attachment 353485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353485&action=review Specifically, what tests is it fixing? > Source/WebCore/platform/soup/PublicSuffixSoup.cpp:49 > + if (!domain.isAllASCII()) > + return domain; Syncing with the Mac implementation seems most important, but now can't the function return a domain that is not the top privately-controlled domain?
(In reply to Michael Catanzaro from comment #2) > Comment on attachment 353485 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353485&action=review > > Specifically, what tests is it fixing? > > > Source/WebCore/platform/soup/PublicSuffixSoup.cpp:49 > > + if (!domain.isAllASCII()) > > + return domain; > > Syncing with the Mac implementation seems most important, but now can't the > function return a domain that is not the top privately-controlled domain? I went back to the origin of that code, and it's here: https://bugs.webkit.org/show_bug.cgi?id=170798 There isn't much of an explanation but I'm guessing that this is not expected to be called with non-ASCII. And all tests pass with this.
Comment on attachment 353485 [details] Patch Clearing flags on attachment: 353485 Committed r237637: <https://trac.webkit.org/changeset/237637>
All reviewed patches have been landed. Closing bug.