Bug 191094 - [lldb-webkit] Fix formatting nits in Document and Frame summary strings
Summary: [lldb-webkit] Fix formatting nits in Document and Frame summary strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-30 17:04 PDT by Daniel Bates
Modified: 2018-11-05 11:36 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.10 KB, patch)
2018-10-30 17:05 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (2.19 KB, patch)
2018-10-31 11:21 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-10-30 17:04:48 PDT
Format boolean as 1/0 when printing Frame summary and substitute "inMainFrame" for "isMainFrame" in Document summary.
Comment 1 Daniel Bates 2018-10-30 17:05:26 PDT
Created attachment 353440 [details]
Patch
Comment 2 Daniel Bates 2018-10-30 21:27:47 PDT
Comment on attachment 353440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353440&action=review

> Tools/lldb/lldb_webkit.py:212
> +    return '{ origin = %s, url = %s, isMainFrame = %d, pageCacheState = %s' % (origin, url, provider.is_main_frame(), pageCacheState)

Oops! I also forgot the closing '}'. So this line should read:

return '{ origin = %s, url = %s, isMainFrame = %d, pageCacheState = %s }' % (origin, url, provider.is_main_frame(), pageCacheState)

> Tools/lldb/lldb_webkit.py:219
> +    return '{ origin = %s, url = %s, inMainFrame = %s, pageCacheState = %s' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state())

Oops! I also forgot the closing '}'. So this line should read:

return '{ origin = %s, url = %s, inMainFrame = %s, pageCacheState = %s }' % (provider.origin(), provider.url(), in_main_frame, provider.page_cache_state())
Comment 3 Daniel Bates 2018-10-31 11:21:35 PDT
Created attachment 353510 [details]
Patch
Comment 4 Daniel Bates 2018-11-05 11:35:50 PST
Comment on attachment 353510 [details]
Patch

Clearing flags on attachment: 353510

Committed r237822: <https://trac.webkit.org/changeset/237822>
Comment 5 Daniel Bates 2018-11-05 11:35:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-05 11:36:24 PST
<rdar://problem/45814199>