Bug 191091 - Add Basic Django web app for OpenSource EWS
Summary: Add Basic Django web app for OpenSource EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-30 16:24 PDT by Aakash Jain
Modified: 2018-11-02 10:36 PDT (History)
8 users (show)

See Also:


Attachments
Proposed patch (55 bytes, patch)
2018-10-31 11:02 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Proposed patch (25.27 KB, patch)
2018-10-31 11:08 PDT, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff
Patch for landing (25.25 KB, patch)
2018-11-02 09:58 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-10-30 16:24:23 PDT
In order to use Buildbot for EWS (https://bugs.webkit.org/show_bug.cgi?id=179506), we need a web-app which act as an intermediate between Buildbot and Bugzilla. This app will receive patches, submit build request to Buildbot, receives build results from Buildbot, and generate status-bubbles which can be displayed on Bugzilla.
Comment 1 Aakash Jain 2018-10-31 11:02:30 PDT
Created attachment 353506 [details]
Proposed patch

Barebone app, mostly Django auto-generated files, and some placeholder files (like models/patch.py). Keeping this patch short so that it is easy to review. Logic would be added in subsequent patches.
Comment 2 Aakash Jain 2018-10-31 11:08:08 PDT
Created attachment 353508 [details]
Proposed patch
Comment 3 EWS Watchlist 2018-10-31 11:10:56 PDT
Attachment 353508 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/EWS_app/manage.py:42:  whitespace before ')'  [pep8/E202] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Lucas Forschler 2018-11-01 13:39:10 PDT
Comment on attachment 353508 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353508&action=review

> Tools/BuildSlaveSupport/EWS_app/EWS_app/settings.py:44
> +SECRET_KEY = 'b)6@_-&5hz(s2-qwt()em3@1yt91=@g=!guu_nz&)u5fb0k+he'

please remove and rotate pw.

> Tools/ChangeLog:9
> +        * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.

I'm not familiar with django development, but is it normal to have a subfolder with the same name as the parent? (EWS_app/EWS_app)?
Comment 5 Kocsen Chung 2018-11-01 13:44:06 PDT
Looks good to me, please fix those style errors :).
Comment 6 Aakash Jain 2018-11-02 09:58:10 PDT
Created attachment 353706 [details]
Patch for landing

> I'm not familiar with django development, but is it normal to have a subfolder with the same name as the parent? (EWS_app/EWS_app)?
Yes, that's normal.

> please remove and rotate pw.
Done.

> Looks good to me, please fix those style errors :).
Thanks. Fixed.
Comment 7 WebKit Commit Bot 2018-11-02 10:35:50 PDT
Comment on attachment 353706 [details]
Patch for landing

Clearing flags on attachment: 353706

Committed r237740: <https://trac.webkit.org/changeset/237740>
Comment 8 WebKit Commit Bot 2018-11-02 10:35:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-11-02 10:36:25 PDT
<rdar://problem/45765964>