Bug 191091 – Add Basic Django web app for OpenSource EWS

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

In order to use Buildbot for EWS (https://bugs.webkit.org/show_bug.cgi?id=179506), we need a web-app which act as an intermediate between Buildbot and Bugzilla. This app will receive patches, submit build request to Buildbot, receives build results from Buildbot, and generate status-bubbles which can be displayed on Bugzilla.

[Aakash Jain]

Created attachment 353506 [details]
Proposed patch

Barebone app, mostly Django auto-generated files, and some placeholder files (like models/patch.py). Keeping this patch short so that it is easy to review. Logic would be added in subsequent patches.

[Aakash Jain]

Created attachment 353508 [details]
Proposed patch

[EWS Watchlist]

Attachment 353508 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/EWS_app/manage.py:42:  whitespace before ')'  [pep8/E202] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Lucas Forschler]

Comment on attachment 353508 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353508&action=review

> Tools/BuildSlaveSupport/EWS_app/EWS_app/settings.py:44
> +SECRET_KEY = 'b)6@_-&5hz(s2-qwt()em3@1yt91=@g=!guu_nz&)u5fb0k+he'

please remove and rotate pw.

> Tools/ChangeLog:9
> +        * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.

I'm not familiar with django development, but is it normal to have a subfolder with the same name as the parent? (EWS_app/EWS_app)?

[Kocsen Chung]

Looks good to me, please fix those style errors :).

[Aakash Jain]

Created attachment 353706 [details]
Patch for landing

> I'm not familiar with django development, but is it normal to have a subfolder with the same name as the parent? (EWS_app/EWS_app)?
Yes, that's normal.

> please remove and rotate pw.
Done.

> Looks good to me, please fix those style errors :).
Thanks. Fixed.

[WebKit Commit Bot]

Comment on attachment 353706 [details]
Patch for landing

Clearing flags on attachment: 353706

Committed r237740: <https://trac.webkit.org/changeset/237740>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45765964>