Bug 191085 - Resync XHR Web Platform Tests from upstream
Summary: Resync XHR Web Platform Tests from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 184645
  Show dependency treegraph
 
Reported: 2018-10-30 15:32 PDT by Chris Dumez
Modified: 2018-10-30 19:31 PDT (History)
8 users (show)

See Also:


Attachments
Patch (75.81 KB, patch)
2018-10-30 15:46 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.55 MB, application/zip)
2018-10-30 16:38 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.70 MB, application/zip)
2018-10-30 16:57 PDT, EWS Watchlist
no flags Details
Patch (81.18 KB, patch)
2018-10-30 17:09 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-10-30 15:32:17 PDT
Resync XHR Web Platform Tests from upstream.
Comment 1 Chris Dumez 2018-10-30 15:46:40 PDT
Created attachment 353420 [details]
Patch
Comment 2 EWS Watchlist 2018-10-30 16:38:37 PDT
Comment on attachment 353420 [details]
Patch

Attachment 353420 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9785468

New failing tests:
imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm
Comment 3 EWS Watchlist 2018-10-30 16:38:39 PDT
Created attachment 353431 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 dewei_zhu 2018-10-30 16:42:54 PDT
Comment on attachment 353420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353420&action=review

> LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34
> +async_test(t => {

Not critical. Both syntax works, but existing tests uses "(t) =>" instead of "t =>", we may want to be consistent.

> LayoutTests/imported/w3c/web-platform-tests/xhr/headers-normalize-response.htm:11
> +    client.open("GET", "resources/parse-headers.py?my-custom-header="+encodeURIComponent(val), false);

Nit: space for each side of  '+'.
Comment 5 EWS Watchlist 2018-10-30 16:57:24 PDT
Comment on attachment 353420 [details]
Patch

Attachment 353420 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9785666

New failing tests:
imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm
Comment 6 EWS Watchlist 2018-10-30 16:57:26 PDT
Created attachment 353438 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 Chris Dumez 2018-10-30 17:03:43 PDT
(In reply to dewei_zhu from comment #4)
> Comment on attachment 353420 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353420&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34
> > +async_test(t => {
> 
> Not critical. Both syntax works, but existing tests uses "(t) =>" instead of
> "t =>", we may want to be consistent.
> 
> > LayoutTests/imported/w3c/web-platform-tests/xhr/headers-normalize-response.htm:11
> > +    client.open("GET", "resources/parse-headers.py?my-custom-header="+encodeURIComponent(val), false);
> 
> Nit: space for each side of  '+'.

Those are imported tests from upstream, I am not going to modify them. They should be exact copies of upstream.
Comment 8 dewei_zhu 2018-10-30 17:04:39 PDT
Comment on attachment 353420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353420&action=review

>>> LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34
>>> +async_test(t => {
>> 
>> Not critical. Both syntax works, but existing tests uses "(t) =>" instead of "t =>", we may want to be consistent.
> 
> Those are imported tests from upstream, I am not going to modify them. They should be exact copies of upstream.

I see.
Comment 9 Chris Dumez 2018-10-30 17:09:21 PDT
Created attachment 353443 [details]
Patch
Comment 10 WebKit Commit Bot 2018-10-30 19:30:43 PDT
Comment on attachment 353443 [details]
Patch

Clearing flags on attachment: 353443

Committed r237618: <https://trac.webkit.org/changeset/237618>
Comment 11 WebKit Commit Bot 2018-10-30 19:30:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2018-10-30 19:31:30 PDT
<rdar://problem/45689421>