Bug 191085 – Resync XHR Web Platform Tests from upstream

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

Resync XHR Web Platform Tests from upstream.

[Chris Dumez]

Created attachment 353420 [details]
Patch

[EWS Watchlist]

Comment on attachment 353420 [details]
Patch

Attachment 353420 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9785468

New failing tests:
imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm

[EWS Watchlist]

Created attachment 353431 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment on attachment 353420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353420&action=review

> LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34
> +async_test(t => {

Not critical. Both syntax works, but existing tests uses "(t) =>" instead of "t =>", we may want to be consistent.

> LayoutTests/imported/w3c/web-platform-tests/xhr/headers-normalize-response.htm:11
> +    client.open("GET", "resources/parse-headers.py?my-custom-header="+encodeURIComponent(val), false);

Nit: space for each side of  '+'.

[EWS Watchlist]

Comment on attachment 353420 [details]
Patch

Attachment 353420 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9785666

New failing tests:
imported/w3c/web-platform-tests/xhr/setrequestheader-content-type.htm

[EWS Watchlist]

Created attachment 353438 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Chris Dumez]

(In reply to dewei_zhu from comment #4)
> Comment on attachment 353420 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353420&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34
> > +async_test(t => {
> 
> Not critical. Both syntax works, but existing tests uses "(t) =>" instead of
> "t =>", we may want to be consistent.
> 
> > LayoutTests/imported/w3c/web-platform-tests/xhr/headers-normalize-response.htm:11
> > +    client.open("GET", "resources/parse-headers.py?my-custom-header="+encodeURIComponent(val), false);
> 
> Nit: space for each side of  '+'.

Those are imported tests from upstream, I am not going to modify them. They should be exact copies of upstream.

Comment on attachment 353420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353420&action=review

>>> LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm:34
>>> +async_test(t => {
>> 
>> Not critical. Both syntax works, but existing tests uses "(t) =>" instead of "t =>", we may want to be consistent.
> 
> Those are imported tests from upstream, I am not going to modify them. They should be exact copies of upstream.

I see.

[Chris Dumez]

Created attachment 353443 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 353443 [details]
Patch

Clearing flags on attachment: 353443

Committed r237618: <https://trac.webkit.org/changeset/237618>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45689421>