Bug 191076 - [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
Summary: [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-30 12:39 PDT by Chris Dumez
Modified: 2018-11-01 13:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (13.52 KB, patch)
2018-10-30 12:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-10-30 12:39:44 PDT 
WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping. The client can request a new load synchronously after answering the policy decision, in which case we'd end up loading the wrong URL.
Comment 1 Chris Dumez 2018-10-30 12:41:06 PDT 
Created attachment 353397 [details]
Patch
Comment 2 Chris Dumez 2018-11-01 09:45:28 PDT 
Ping review?
Comment 3 Geoffrey Garen 2018-11-01 13:44:23 PDT 
Comment on attachment 353397 [details]
Patch

r=me
Comment 4 Chris Dumez 2018-11-01 13:53:55 PDT 
Comment on attachment 353397 [details]
Patch

Clearing flags on attachment: 353397

Committed r237699: <https://trac.webkit.org/changeset/237699>
Comment 5 Chris Dumez 2018-11-01 13:53:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-01 13:54:22 PDT 
<rdar://problem/45740845>