Bug 191075 - XSLTProcessor should limit max transform depth
Summary: XSLTProcessor should limit max transform depth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-30 12:38 PDT by David Kilzer (:ddkilzer)
Modified: 2018-10-30 20:36 PDT (History)
12 users (show)

See Also:

Attachments
Patch v1 (8.52 KB, patch)
2018-10-30 12:46 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Patch v2 (8.72 KB, patch)
2018-10-30 13:01 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-10-30 12:38:09 PDT 
XSLTProcessor should limit max transform depth to a reasonable amount.

The default for libxslt is currently 3000.

<rdar://problem/45531453>
Comment 1 David Kilzer (:ddkilzer) 2018-10-30 12:46:24 PDT 
Created attachment 353398 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2018-10-30 12:59:17 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #1)
> Created attachment 353398 [details]
> Patch v1

Due to soft-linking, I'll need to modify the code to work with Apple platforms (using soft-linking) and non-Apple platforms without soft-linking.
Comment 3 David Kilzer (:ddkilzer) 2018-10-30 13:01:53 PDT 
Created attachment 353399 [details]
Patch v2
Comment 4 WebKit Commit Bot 2018-10-30 20:36:40 PDT 
Comment on attachment 353399 [details]
Patch v2

Clearing flags on attachment: 353399

Committed r237620: <https://trac.webkit.org/changeset/237620>
Comment 5 WebKit Commit Bot 2018-10-30 20:36:42 PDT 
All reviewed patches have been landed.  Closing bug.