Enable building for PlayStation up through JavaScriptCore
Created attachment 353425 [details] Patch Adds in the PlayStation port building WTF + JSC + TestWTF.
Attachment 353425 [details] did not pass style-queue: ERROR: Source/ThirdParty/gtest/PlatformPlayStation.cmake:5: Alphabetical sorting problem. "-DGTEST_HAS_TR1_TUPLE=0" should be before "# There is no <tr1/tuple> header". [list/order] [5] ERROR: Source/ThirdParty/gtest/PlatformPlayStation.cmake:6: Alphabetical sorting problem. "# Posix Regex not present so use gtest implementation" should be before "-DGTEST_HAS_TR1_TUPLE=0". [list/order] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 353426 [details] Patch
Attachment 353426 [details] did not pass style-queue: ERROR: Source/ThirdParty/gtest/PlatformPlayStation.cmake:5: There should be exactly one empty line instead of 0 between "-DGTEST_HAS_POSIX_RE=0 # Posix Regex not present so use gtest implementation" and "-DGTEST_HAS_TR1_TUPLE=0 # There is no <tr1/tuple> header". [list/emptyline] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 353429 [details] Patch
Comment on attachment 353429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353429&action=review These changes all seem well isolated to the PlayStation port. I don't see any reason why this would pose a problem to land, assuming the build system is happy. > CMakeLists.txt:43 > + PlayStation Woohoo! > Tools/Scripts/webkitdirs.pm:2310 > + push @args, '-G "Visual Studio 15"'; Does the PS build not support VS 2017?
Comment on attachment 353429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353429&action=review Thanks for the review! > Tools/Scripts/webkitdirs.pm:2311 > } Yep we have a visual studio integration!
Comment on attachment 353429 [details] Patch Clearing flags on attachment: 353429 Committed r237621: <https://trac.webkit.org/changeset/237621>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45690705>