Bug 191070 - [iOS] Use the mainframe view size to compute window.outerWidth/height.
Summary: [iOS] Use the mainframe view size to compute window.outerWidth/height.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-10-30 10:46 PDT by zalan
Modified: 2018-10-30 13:17 PDT (History)
5 users (show)

See Also:

Patch (1.97 KB, patch)
2018-10-30 10:50 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-10-30 10:46:06 PDT
WKWebView's frame rect -> drawing area sizing -> WebPage's view size -> FrameView size
Comment 1 zalan 2018-10-30 10:49:37 PDT
Comment 2 zalan 2018-10-30 10:50:07 PDT
Created attachment 353385 [details]
Comment 3 WebKit Commit Bot 2018-10-30 11:33:09 PDT
Comment on attachment 353385 [details]

Clearing flags on attachment: 353385

Committed r237596: <https://trac.webkit.org/changeset/237596>
Comment 4 WebKit Commit Bot 2018-10-30 11:33:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Fraser (smfr) 2018-10-30 13:17:18 PDT
Comment on attachment 353385 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=353385&action=review

> Source/WebCore/page/DOMWindow.cpp:1183
> +    auto* view = frame()->isMainFrame() ? frame()->view() : frame()->mainFrame().view();

Is frame()->mainFrame().view() == frame()->view() for the main frame (i.e. do you need this ternary at all?).