WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
191070
[iOS] Use the mainframe view size to compute window.outerWidth/height.
https://bugs.webkit.org/show_bug.cgi?id=191070
Summary
[iOS] Use the mainframe view size to compute window.outerWidth/height.
alan baradlay
Reported
2018-10-30 10:46:06 PDT
WKWebView's frame rect -> drawing area sizing -> WebPage's view size -> FrameView size
Attachments
Patch
(1.97 KB, patch)
2018-10-30 10:50 PDT
,
alan baradlay
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
alan baradlay
Comment 1
2018-10-30 10:49:37 PDT
rdar://problem/42368377
alan baradlay
Comment 2
2018-10-30 10:50:07 PDT
Created
attachment 353385
[details]
Patch
WebKit Commit Bot
Comment 3
2018-10-30 11:33:09 PDT
Comment on
attachment 353385
[details]
Patch Clearing flags on attachment: 353385 Committed
r237596
: <
https://trac.webkit.org/changeset/237596
>
WebKit Commit Bot
Comment 4
2018-10-30 11:33:10 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 5
2018-10-30 13:17:18 PDT
Comment on
attachment 353385
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=353385&action=review
> Source/WebCore/page/DOMWindow.cpp:1183 > + auto* view = frame()->isMainFrame() ? frame()->view() : frame()->mainFrame().view();
Is frame()->mainFrame().view() == frame()->view() for the main frame (i.e. do you need this ternary at all?).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug