Bug 191065 - Stop using LayerFlushScheduler in WK2
Summary: Stop using LayerFlushScheduler in WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 191103
  Show dependency tree / graph
 
Reported: 2018-10-30 06:05 PDT by Antti Koivisto
Modified: 2018-10-31 02:57 PDT (History)
6 users (show)

See Also:

Attachments
patch (7.52 KB, patch)
2018-10-30 06:12 PDT, Antti Koivisto 		thorton: review+
Details | Formatted Diff | Diff
patch (7.99 KB, patch)
2018-10-31 02:19 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-10-30 06:05:28 PDT 
Code gets more understandable when TiledCoreAnimationDrawingArea simply uses RunLoopObserver directly for flush scheduling. LayerFlushScheduler can be later moved to WK1.
Comment 1 Antti Koivisto 2018-10-30 06:12:59 PDT 
Created attachment 353364 [details]
patch
Comment 2 Tim Horton 2018-10-30 10:07:58 PDT 
Comment on attachment 353364 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353364&action=review

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:901
> +    if (layerTreeStateIsFrozen())

Should this just go inside flushLayers()?
Comment 3 Simon Fraser (smfr) 2018-10-30 13:16:02 PDT 
Comment on attachment 353364 [details]
patch

Layer flushing time is going to become our "before paint" hook for firing requestAnimationFrame et (first bits of HTML5 event loop). We should work towards that goal.
Comment 4 Antti Koivisto 2018-10-31 02:19:40 PDT 
Created attachment 353474 [details]
patch
Comment 5 WebKit Commit Bot 2018-10-31 02:56:56 PDT 
Comment on attachment 353474 [details]
patch

Clearing flags on attachment: 353474

Committed r237629: <https://trac.webkit.org/changeset/237629>
Comment 6 WebKit Commit Bot 2018-10-31 02:56:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-31 02:57:22 PDT 
<rdar://problem/45695991>