Bug 191051 - Add credit card autofill button
Summary: Add credit card autofill button
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-29 18:15 PDT by Zach Li
Modified: 2023-07-02 08:26 PDT (History)
8 users (show)

See Also:

Attachments
Patch (24.13 KB, patch)
2018-10-29 18:35 PDT, Zach Li 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.33 MB, application/zip)
2018-10-29 20:33 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews200 for win-future (12.97 MB, application/zip)
2018-10-30 04:38 PDT, EWS Watchlist 		no flags Details
Patch and updated layout tests (30.45 KB, patch)
2018-10-30 11:20 PDT, Zach Li 		no flags Details | Formatted Diff | Diff
Patch and updated layout tests (30.47 KB, text/plain)
2018-10-30 11:53 PDT, Zach Li 		no flags Details
Patch and updated layout tests (30.47 KB, patch)
2018-10-30 11:53 PDT, Zach Li 		no flags Details | Formatted Diff | Diff
Patch and updated layout tests (39.21 KB, patch)
2018-10-30 13:20 PDT, Zach Li 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zach Li 2018-10-29 18:15:56 PDT 
Add credit card autofill button, rdar://problem/45657011.
Comment 1 Zach Li 2018-10-29 18:35:52 PDT 
Created attachment 353340 [details]
Patch
Comment 2 EWS Watchlist 2018-10-29 20:32:59 PDT 
Comment on attachment 353340 [details]
Patch

Attachment 353340 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9774478

New failing tests:
fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html
Comment 3 EWS Watchlist 2018-10-29 20:33:01 PDT 
Created attachment 353351 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 4 EWS Watchlist 2018-10-30 04:38:33 PDT 
Comment on attachment 353340 [details]
Patch

Attachment 353340 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9777551

New failing tests:
fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html
Comment 5 EWS Watchlist 2018-10-30 04:38:44 PDT 
Created attachment 353360 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Zach Li 2018-10-30 11:20:44 PDT 
Created attachment 353390 [details]
Patch and updated layout tests
Comment 7 Zach Li 2018-10-30 11:21:33 PDT 
rdar://problem/45657011
Comment 8 Zach Li 2018-10-30 11:53:14 PDT 
Created attachment 353392 [details]
Patch and updated layout tests
Comment 9 Zach Li 2018-10-30 11:53:53 PDT 
Created attachment 353393 [details]
Patch and updated layout tests
Comment 10 Zach Li 2018-10-30 13:20:28 PDT 
Created attachment 353402 [details]
Patch and updated layout tests
Comment 11 WebKit Commit Bot 2018-10-31 13:08:51 PDT 
Comment on attachment 353402 [details]
Patch and updated layout tests

Clearing flags on attachment: 353402

Committed r237647: <https://trac.webkit.org/changeset/237647>
Comment 12 WebKit Commit Bot 2018-10-31 13:08:52 PDT 
All reviewed patches have been landed.  Closing bug.