Bug 191049 – Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category.

Created attachment 353333 [details]
Patch

[Chris Dumez]

Comment on attachment 353333 [details]
Patch

r=me

[Chris Dumez]

Comment on attachment 353333 [details]
Patch

Clearing flags on attachment: 353333

Committed r237573: <https://trac.webkit.org/changeset/237573>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

Reopening to attach new patch.

Created attachment 353334 [details]
Patch for landing

[Radar WebKit Bug Importer]

<rdar://problem/45654625>

[WebKit Commit Bot]

Comment on attachment 353334 [details]
Patch for landing

Rejecting attachment 353334 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 353334, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=353334&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=191049&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 353334 from bug 191049.
Fetching: https://bugs.webkit.org/attachment.cgi?id=353334
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/Shared/WebPreferences.yaml
Hunk #1 FAILED at 1350.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/WebPreferences.yaml.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/9773376

[Chris Dumez]

I already landed it in https://trac.webkit.org/changeset/237573

[Dean Jackson]

Comment on attachment 353334 [details]
Patch for landing

Could you also move the entire feature into the section with other experimental features? (A few lines above this)

Will do in a followup fix.

Reopening to attach new patch.

Created attachment 353445 [details]
Patch

[Dean Jackson]

Comment on attachment 353445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353445&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1340
> +type: bool
> +defaultValue: false
> +humanReadableName: "Swap Processes on Cross-Site Navigation"
> +humanReadableDescription: "Swap WebContent processes on cross-site navigations"
> +category: experimental
> +webcoreBinding: none

Nit: indentation.

Comment on attachment 353445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353445&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:1340
>> +webcoreBinding: none
> 
> Nit: indentation.

Nice catch. Tricked by Xcode.

Landed in r237611.