RESOLVED FIXED 191043
Enable InstallAPI for iOS unconditionally 
https://bugs.webkit.org/show_bug.cgi?id=191043
Summary Enable InstallAPI for iOS unconditionally
Alexey Proskuryakov
Reported 2018-10-29 15:02:03 PDT
It's currently only enabled when using internal SDK. rdar://problem/32728423
Attachments
proposed patch (11.00 KB, patch)
2018-10-29 15:08 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-10-29 15:08:44 PDT
Created attachment 353326 [details] proposed patch
Alexey Proskuryakov
Comment 2 2018-10-29 15:10:04 PDT
Took the NSURLDownloadSPI trick from Dan's patch in bug 184225.
mitz
Comment 3 2018-10-29 15:26:14 PDT
(In reply to Alexey Proskuryakov from comment #2) > Took the NSURLDownloadSPI trick from Dan's patch in bug 184225. This doesn’t seem to include a crucial (at the time) bit of that patch. Namely, as it stands, this patch appears to have a public header (WebDownload.h) importing a private header (NSURLDownloadSPI.h). Not a problem?
Alexey Proskuryakov
Comment 4 2018-10-29 15:54:55 PDT
WebDownload.h appears to be a private header, am I missing something?
Alexey Proskuryakov
Comment 5 2018-10-29 16:04:15 PDT
WebDownload.h is re-exported by WebKit as public on macOS, which is fine. NSURLDownloadSPI.h is not imported on macOS.
WebKit Commit Bot
Comment 6 2018-10-30 13:41:45 PDT
Comment on attachment 353326 [details] proposed patch Clearing flags on attachment: 353326 Committed r237600: <https://trac.webkit.org/changeset/237600>
WebKit Commit Bot
Comment 7 2018-10-30 13:41:46 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2018-10-30 15:13:03 PDT
Build fix attempt in r237604.
WebKit Commit Bot
Comment 9 2018-10-30 15:32:32 PDT
Re-opened since this is blocked by bug 191086
Alexey Proskuryakov
Comment 10 2018-10-30 17:19:20 PDT
Re-landed in https://trac.webkit.org/r237610.
Note You need to log in before you can comment on or make changes to this bug.