Bug 191043 - Enable InstallAPI for iOS unconditionally
Summary: Enable InstallAPI for iOS unconditionally
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar
Depends on: 191086
  Show dependency treegraph
Reported: 2018-10-29 15:02 PDT by Alexey Proskuryakov
Modified: 2018-10-30 17:19 PDT (History)
4 users (show)

See Also:

proposed patch (11.00 KB, patch)
2018-10-29 15:08 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-10-29 15:02:03 PDT
It's currently only enabled when using internal SDK.

Comment 1 Alexey Proskuryakov 2018-10-29 15:08:44 PDT
Created attachment 353326 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2018-10-29 15:10:04 PDT
Took the NSURLDownloadSPI trick from Dan's patch in bug 184225.
Comment 3 mitz 2018-10-29 15:26:14 PDT
(In reply to Alexey Proskuryakov from comment #2)
> Took the NSURLDownloadSPI trick from Dan's patch in bug 184225.

This doesn’t seem to include a crucial (at the time) bit of that patch. Namely, as it stands, this patch appears to have a public header (WebDownload.h) importing a private header (NSURLDownloadSPI.h). Not a problem?
Comment 4 Alexey Proskuryakov 2018-10-29 15:54:55 PDT
WebDownload.h appears to be a private header, am I missing something?
Comment 5 Alexey Proskuryakov 2018-10-29 16:04:15 PDT
WebDownload.h is re-exported by WebKit as public on macOS, which is fine. NSURLDownloadSPI.h is not imported on macOS.
Comment 6 WebKit Commit Bot 2018-10-30 13:41:45 PDT
Comment on attachment 353326 [details]
proposed patch

Clearing flags on attachment: 353326

Committed r237600: <https://trac.webkit.org/changeset/237600>
Comment 7 WebKit Commit Bot 2018-10-30 13:41:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2018-10-30 15:13:03 PDT
Build fix attempt in r237604.
Comment 9 WebKit Commit Bot 2018-10-30 15:32:32 PDT
Re-opened since this is blocked by bug 191086
Comment 10 Alexey Proskuryakov 2018-10-30 17:19:20 PDT
Re-landed in https://trac.webkit.org/r237610.