Bug 191033 - [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
Summary: [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2018-10-29 11:13 PDT by Daniel Bates
Modified: 2018-10-29 13:56 PDT (History)
5 users (show)

See Also:

Patch (8.34 KB, patch)
2018-10-29 11:16 PDT, Daniel Bates
aestes: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-10-29 11:13:27 PDT
We should add summaries for Document, Frame, and SecurityOrigin so that a person can ascertain common properties of these objects at a glance.
Comment 1 Daniel Bates 2018-10-29 11:15:38 PDT
We need to fix bug #187916 to be able to isolate lldb-webkit tests from webkitpy tests and hence write tests for WebCore LLDB summary providers without requiring webkitpy developers to build the world.
Comment 2 Daniel Bates 2018-10-29 11:16:55 PDT
Created attachment 353301 [details]
Comment 3 Andy Estes 2018-10-29 11:23:00 PDT
Comment on attachment 353301 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=353301&action=review

> Tools/ChangeLog:8
> +        For Documents we display its origin, URL, whether its in the main frame, and its page cache state.

whether it's*
Comment 4 Daniel Bates 2018-10-29 13:55:41 PDT
Committed r237563: <https://trac.webkit.org/changeset/237563>
Comment 5 Radar WebKit Bug Importer 2018-10-29 13:56:26 PDT