RESOLVED FIXED 191033
[llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin 
https://bugs.webkit.org/show_bug.cgi?id=191033
Summary [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
Daniel Bates
Reported 2018-10-29 11:13:27 PDT
We should add summaries for Document, Frame, and SecurityOrigin so that a person can ascertain common properties of these objects at a glance.
Attachments
Patch (8.34 KB, patch)
2018-10-29 11:16 PDT, Daniel Bates 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-10-29 11:15:38 PDT
We need to fix bug #187916 to be able to isolate lldb-webkit tests from webkitpy tests and hence write tests for WebCore LLDB summary providers without requiring webkitpy developers to build the world.
Daniel Bates
Comment 2 2018-10-29 11:16:55 PDT
Created attachment 353301 [details] Patch
Andy Estes
Comment 3 2018-10-29 11:23:00 PDT
Comment on attachment 353301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353301&action=review > Tools/ChangeLog:8 > + For Documents we display its origin, URL, whether its in the main frame, and its page cache state. whether it's*
Daniel Bates
Comment 4 2018-10-29 13:55:41 PDT
Committed r237563: <https://trac.webkit.org/changeset/237563>
Radar WebKit Bug Importer
Comment 5 2018-10-29 13:56:26 PDT
<rdar://problem/45648087>
Note You need to log in before you can comment on or make changes to this bug.