Bug 191031 - [GTK][WPE] Fixes to the PublicSuffix implementation
Summary: [GTK][WPE] Fixes to the PublicSuffix implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-29 09:08 PDT by Claudio Saavedra
Modified: 2018-10-30 01:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.37 KB, patch)
2018-10-29 09:11 PDT, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2018-10-29 09:08:52 PDT 
[GTK][WPE] Fixes to the PublicSuffix implementation
Comment 1 Claudio Saavedra 2018-10-29 09:11:55 PDT 
Created attachment 353291 [details]
Patch
Comment 2 Claudio Saavedra 2018-10-29 09:14:48 PDT 
With this patch there are these two failures. I am not familiar with the r4--- prefix, is that something we should be able to decode or just noise?

../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:170
Expected equality of these values:
  String()
    Which is: 
  topPrivatelyControlledDomain("1")
    Which is: 1


../../Tools/TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:174
Expected equality of these values:
  String()
    Which is: 
  topPrivatelyControlledDomain("r4---asdf")
    Which is: r4---asdf
Comment 3 Claudio Saavedra 2018-10-29 09:15:51 PDT 
NB: I am removing the test for 栃木.jp as it's a public-suffix and I don't think it should be tested where it currently is.
Comment 4 Michael Catanzaro 2018-10-29 11:38:55 PDT 
(In reply to Claudio Saavedra from comment #2)
> With this patch there are these two failures. I am not familiar with the
> r4--- prefix, is that something we should be able to decode or just noise?

I don't know IDN. No clue.
Comment 5 WebKit Commit Bot 2018-10-30 01:27:04 PDT 
Comment on attachment 353291 [details]
Patch

Clearing flags on attachment: 353291

Committed r237584: <https://trac.webkit.org/changeset/237584>
Comment 6 WebKit Commit Bot 2018-10-30 01:27:06 PDT 
All reviewed patches have been landed.  Closing bug.