Bug 191028 - Implement PostMessageOptions for postMessage
Summary: Implement PostMessageOptions for postMessage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 205167 (view as bug list)
Depends on: 205178 205180 205181
Blocks: 205120
  Show dependency tree / graph
 
Reported: 2018-10-29 06:43 PDT by David Tapuska
Modified: 2019-12-13 13:37 PST (History)
18 users (show)

See Also:

Attachments
WIP Patch (32.67 KB, patch)
2019-12-12 13:09 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (33.44 KB, patch)
2019-12-12 13:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (42.10 KB, patch)
2019-12-12 14:00 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (46.62 KB, patch)
2019-12-12 15:23 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (56.66 KB, patch)
2019-12-12 18:16 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (65.93 KB, patch)
2019-12-12 18:22 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (65.97 KB, patch)
2019-12-13 08:21 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (68.94 KB, patch)
2019-12-13 12:13 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Chris Dumez 2019-12-12 13:09:47 PST 
Created attachment 385537 [details]
WIP Patch
Comment 2 Chris Dumez 2019-12-12 13:37:09 PST 
Created attachment 385542 [details]
WIP Patch
Comment 3 Chris Dumez 2019-12-12 14:00:21 PST 
Created attachment 385547 [details]
WIP Patch
Comment 4 Chris Dumez 2019-12-12 14:01:12 PST 
*** Bug 205167 has been marked as a duplicate of this bug. ***
Comment 5 Chris Dumez 2019-12-12 15:23:03 PST 
Created attachment 385557 [details]
WIP Patch
Comment 6 Chris Dumez 2019-12-12 18:16:40 PST 
Created attachment 385569 [details]
WIP Patch
Comment 7 Chris Dumez 2019-12-12 18:22:56 PST 
Created attachment 385570 [details]
Patch
Comment 8 Chris Dumez 2019-12-13 08:21:59 PST 
Created attachment 385603 [details]
Patch
Comment 9 Chris Dumez 2019-12-13 12:13:14 PST 
Created attachment 385629 [details]
Patch
Comment 10 Alex Christensen 2019-12-13 12:31:29 PST 
Comment on attachment 385629 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385629&action=review

> Source/WebCore/workers/service/ServiceWorker.cpp:115
>      Vector<RefPtr<MessagePort>> ports;

It would be nice if this could be part of the return value.
Comment 11 Chris Dumez 2019-12-13 13:36:32 PST 
Comment on attachment 385629 [details]
Patch

Clearing flags on attachment: 385629

Committed r253497: <https://trac.webkit.org/changeset/253497>
Comment 12 Chris Dumez 2019-12-13 13:36:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2019-12-13 13:37:20 PST 
<rdar://problem/57923441>