LibWebRTCRtpReceiverBackend::getSynchronizationSources should use Vector::append
Created attachment 353281 [details] Patch
Created attachment 353284 [details] Patch
Comment on attachment 353284 [details] Patch Attachment 353284 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9767339 New failing tests: webrtc/video-addTransceiver.html
Created attachment 353287 [details] Archive of layout-test-results from ews105 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 353289 [details] Patch
Comment on attachment 353289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353289&action=review > LayoutTests/webrtc/video-addTransceiver.html:114 > + if (sources.length) { Why do this test, shouldn't it be the same from run to run?
(In reply to Eric Carlson from comment #6) > Comment on attachment 353289 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353289&action=review > > > LayoutTests/webrtc/video-addTransceiver.html:114 > > + if (sources.length) { > > Why do this test, shouldn't it be the same from run to run? I get a consistent number of sources locally but not on bots. Slowness of bots probably affects gathering of the results.
Comment on attachment 353289 [details] Patch Clearing flags on attachment: 353289 Committed r237585: <https://trac.webkit.org/changeset/237585>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45663844>