Web Inspector: Styles: missing contextmenu items for links

[Devin Rousso]

The contextmenu of styles with links should show the usual "Open in New Tab" and "Copy Link Address" options.

[Devin Rousso]

Created attachment 353277 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 353277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353277&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:97
>      contextMenu.appendItem(WI.UIString("Open in New Tab"), () => {

Hmm, Safari doesn't show "Open in New Tab" if the link is a `javascript:` link. I think we should probably do the same for `javascript:` / `data:` and maybe all non-http/https links.

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:117
>      contextMenu.appendItem(WI.UIString("Copy Link Address"), () => {

Hmm, Safari shows "Copy Link" instead of "Copy Link Address". I think we should probably update our text.

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:708
> +        WI.appendContextMenuItemsForURL(contextMenu, token.value);

Does this work with both an absolute and relative URL?

[Devin Rousso]

Created attachment 353349 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 353349 [details]
Patch

Clearing flags on attachment: 353349

Committed r237660: <https://trac.webkit.org/changeset/237660>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45716821>