RESOLVED FIXED 191021
Web Inspector: Styles: missing contextmenu items for links 
https://bugs.webkit.org/show_bug.cgi?id=191021
Summary Web Inspector: Styles: missing contextmenu items for links
Devin Rousso
Reported 2018-10-29 00:10:00 PDT
The contextmenu of styles with links should show the usual "Open in New Tab" and "Copy Link Address" options.
Attachments
Patch (4.04 KB, patch)
2018-10-29 00:11 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (6.85 KB, patch)
2018-10-29 19:58 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-29 00:11:39 PDT
Created attachment 353277 [details] Patch
Joseph Pecoraro
Comment 2 2018-10-29 16:38:49 PDT
Comment on attachment 353277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353277&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:97 > contextMenu.appendItem(WI.UIString("Open in New Tab"), () => { Hmm, Safari doesn't show "Open in New Tab" if the link is a `javascript:` link. I think we should probably do the same for `javascript:` / `data:` and maybe all non-http/https links. > Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:117 > contextMenu.appendItem(WI.UIString("Copy Link Address"), () => { Hmm, Safari shows "Copy Link" instead of "Copy Link Address". I think we should probably update our text. > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:708 > + WI.appendContextMenuItemsForURL(contextMenu, token.value); Does this work with both an absolute and relative URL?
Devin Rousso
Comment 3 2018-10-29 19:58:18 PDT
Created attachment 353349 [details] Patch
WebKit Commit Bot
Comment 4 2018-10-31 16:57:37 PDT
Comment on attachment 353349 [details] Patch Clearing flags on attachment: 353349 Committed r237660: <https://trac.webkit.org/changeset/237660>
WebKit Commit Bot
Comment 5 2018-10-31 16:57:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-10-31 16:58:34 PDT
<rdar://problem/45716821>
Note You need to log in before you can comment on or make changes to this bug.