Bug 191015 - [WPE] Add the WebKitVersion.h header
Summary: [WPE] Add the WebKitVersion.h header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-28 10:11 PDT by Zan Dobersek
Modified: 2018-11-03 07:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.99 KB, patch)
2018-10-28 10:15 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (16.17 KB, patch)
2018-10-28 23:46 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-10-28 10:11:22 PDT 
[WPE] Add the WebKitVersion.h header
Comment 1 Zan Dobersek 2018-10-28 10:15:37 PDT 
Created attachment 353260 [details]
Patch
Comment 2 Zan Dobersek 2018-10-28 23:46:20 PDT 
Created attachment 353275 [details]
Patch for landing
Comment 3 Zan Dobersek 2018-10-28 23:48:37 PDT 
Comment on attachment 353275 [details]
Patch for landing

Clearing flags on attachment: 353275

Committed r237541: <https://trac.webkit.org/changeset/237541>
Comment 4 Zan Dobersek 2018-10-28 23:48:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-10-29 13:32:58 PDT 
<rdar://problem/45647211>
Comment 6 Radar WebKit Bug Importer 2018-10-29 13:33:03 PDT 
<rdar://problem/45647216>
Comment 7 Philippe Normand 2018-11-03 05:36:55 PDT 
The generated header is not installed. I fixed it locally with:

diff --git a/Source/WebKit/PlatformWPE.cmake b/Source/WebKit/PlatformWPE.cmake
index 6668d36c0eb..86095d1ac5f 100644
--- a/Source/WebKit/PlatformWPE.cmake
+++ b/Source/WebKit/PlatformWPE.cmake
@@ -93,6 +93,7 @@ list(APPEND WebKit_DERIVED_SOURCES
 
 set(WPE_API_INSTALLED_HEADERS
     ${DERIVED_SOURCES_WPE_API_DIR}/WebKitEnumTypes.h
+    ${DERIVED_SOURCES_WPE_API_DIR}/WebKitVersion.h
     ${WEBKIT_DIR}/UIProcess/API/wpe/WebKitApplicationInfo.h
     ${WEBKIT_DIR}/UIProcess/API/wpe/WebKitAuthenticationRequest.h
     ${WEBKIT_DIR}/UIProcess/API/wpe/WebKitAutomationSession.h


r?
Comment 8 Michael Catanzaro 2018-11-03 07:09:09 PDT 
Ooops. Yes, r=me.
Comment 9 Philippe Normand 2018-11-03 07:30:47 PDT 
Committed r237772