[LFC][IFC] Add support for simple intruding floats.

[zalan]

intruding floats from parent formatting context.

[zalan]

Created attachment 353249 [details]
Patch

[EWS Watchlist]

Comment on attachment 353249 [details]
Patch

Attachment 353249 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/9753895

New failing tests:
fast/inline/simple-intruding-float1.html

[EWS Watchlist]

Created attachment 353250 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Antti Koivisto]

Comment on attachment 353249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353249&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:246
> +    // For formatting roots, we already precomputed final position.

Should we assert that?

> Source/WebCore/layout/floats/FloatingState.cpp:115
> -        if (!(rect.top() <= verticalPosition && verticalPosition < rect.bottom()))
> +        if (!(rect.top() <= adjustedPosition.y && adjustedPosition.y < rect.bottom()))
>              continue;

Ninja fix?

[zalan]

(In reply to Antti Koivisto from comment #4)
> Comment on attachment 353249 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353249&action=review
> 
> > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:246
> > +    // For formatting roots, we already precomputed final position.
> 
> Should we assert that?
Good point. I added that.
> 
> > Source/WebCore/layout/floats/FloatingState.cpp:115
> > -        if (!(rect.top() <= verticalPosition && verticalPosition < rect.bottom()))
> > +        if (!(rect.top() <= adjustedPosition.y && adjustedPosition.y < rect.bottom()))
> >              continue;
> 
> Ninja fix?
Totally.

[zalan]

Committed r237549: <https://trac.webkit.org/changeset/237549>

[Radar WebKit Bug Importer]

<rdar://problem/45647194>