RESOLVED FIXED 190998
[LFC][IFC] Add support for simple intruding floats. 
https://bugs.webkit.org/show_bug.cgi?id=190998
Summary [LFC][IFC] Add support for simple intruding floats.
alan
Reported 2018-10-27 16:20:10 PDT
intruding floats from parent formatting context.
Attachments
Patch (12.22 KB, patch)
2018-10-27 16:28 PDT, alan 		koivisto: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.77 MB, application/zip)
2018-10-27 18:05 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-10-27 16:28:56 PDT
Created attachment 353249 [details] Patch
EWS Watchlist
Comment 2 2018-10-27 18:05:43 PDT
Comment on attachment 353249 [details] Patch Attachment 353249 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9753895 New failing tests: fast/inline/simple-intruding-float1.html
EWS Watchlist
Comment 3 2018-10-27 18:05:54 PDT
Created attachment 353250 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Antti Koivisto
Comment 4 2018-10-29 05:42:48 PDT
Comment on attachment 353249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353249&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:246 > + // For formatting roots, we already precomputed final position. Should we assert that? > Source/WebCore/layout/floats/FloatingState.cpp:115 > - if (!(rect.top() <= verticalPosition && verticalPosition < rect.bottom())) > + if (!(rect.top() <= adjustedPosition.y && adjustedPosition.y < rect.bottom())) > continue; Ninja fix?
alan
Comment 5 2018-10-29 07:35:24 PDT
(In reply to Antti Koivisto from comment #4) > Comment on attachment 353249 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353249&action=review > > > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:246 > > + // For formatting roots, we already precomputed final position. > > Should we assert that? Good point. I added that. > > > Source/WebCore/layout/floats/FloatingState.cpp:115 > > - if (!(rect.top() <= verticalPosition && verticalPosition < rect.bottom())) > > + if (!(rect.top() <= adjustedPosition.y && adjustedPosition.y < rect.bottom())) > > continue; > > Ninja fix? Totally.
alan
Comment 6 2018-10-29 07:35:25 PDT
Committed r237549: <https://trac.webkit.org/changeset/237549>
Radar WebKit Bug Importer
Comment 7 2018-10-29 13:32:33 PDT
<rdar://problem/45647194>
Note You need to log in before you can comment on or make changes to this bug.