RESOLVED FIXED 190996
[Web Animations] Move bindings methods requiring style flush from CSSAnimation to DeclarativeAnimation 
https://bugs.webkit.org/show_bug.cgi?id=190996
Summary [Web Animations] Move bindings methods requiring style flush from CSSAnimatio...
Antoine Quint
Reported 2018-10-27 13:59:05 PDT
[Web Animations] Move bindings methods requiring style flush from CSSAnimation to DeclarativeAnimation
Attachments
Patch (10.00 KB, patch)
2018-10-27 14:01 PDT, Antoine Quint 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-10-27 14:01:39 PDT
Created attachment 353246 [details] Patch
Dean Jackson
Comment 2 2018-10-27 14:04:09 PDT
Comment on attachment 353246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353246&action=review > Source/WebCore/animation/CSSAnimation.cpp:-126 > - auto currentTime = DeclarativeAnimation::bindingsCurrentTime(); > - if (currentTime) { > - if (auto* animationEffect = effect()) > - return std::max(0.0, std::min(currentTime.value(), animationEffect->timing()->activeDuration().milliseconds())); > - } > - return currentTime; is this logic in WebAnimation::bindingsCurrentTime?
Antoine Quint
Comment 3 2018-10-27 14:08:54 PDT
This code was actually not necessary. Will make a note in the ChangeLog when landing.
Antoine Quint
Comment 4 2018-10-28 00:51:50 PDT
Committed r237498: <https://trac.webkit.org/changeset/237498>
Radar WebKit Bug Importer
Comment 5 2018-10-28 00:52:31 PDT
<rdar://problem/45617858>
Note You need to log in before you can comment on or make changes to this bug.