Bug 190996 - [Web Animations] Move bindings methods requiring style flush from CSSAnimation to DeclarativeAnimation
Summary: [Web Animations] Move bindings methods requiring style flush from CSSAnimatio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-27 13:59 PDT by Antoine Quint
Modified: 2018-10-28 00:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.00 KB, patch)
2018-10-27 14:01 PDT, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-10-27 13:59:05 PDT 
[Web Animations] Move bindings methods requiring style flush from CSSAnimation to DeclarativeAnimation
Comment 1 Antoine Quint 2018-10-27 14:01:39 PDT 
Created attachment 353246 [details]
Patch
Comment 2 Dean Jackson 2018-10-27 14:04:09 PDT 
Comment on attachment 353246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353246&action=review

> Source/WebCore/animation/CSSAnimation.cpp:-126
> -    auto currentTime = DeclarativeAnimation::bindingsCurrentTime();
> -    if (currentTime) {
> -        if (auto* animationEffect = effect())
> -            return std::max(0.0, std::min(currentTime.value(), animationEffect->timing()->activeDuration().milliseconds()));
> -    }
> -    return currentTime;

is this logic in WebAnimation::bindingsCurrentTime?
Comment 3 Antoine Quint 2018-10-27 14:08:54 PDT 
This code was actually not necessary. Will make a note in the ChangeLog when landing.
Comment 4 Antoine Quint 2018-10-28 00:51:50 PDT 
Committed r237498: <https://trac.webkit.org/changeset/237498>
Comment 5 Radar WebKit Bug Importer 2018-10-28 00:52:31 PDT 
<rdar://problem/45617858>